You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "Jeff-Lv (GitHub)" <gi...@apache.org> on 2018/12/27 08:09:05 UTC

[GitHub] [incubator-dubbo] Jeff-Lv opened pull request #3078: import a pojo ServiceMeta which is used as service level info

## What is the purpose of the change

If URL is used for data transferred before loadbalancer decides the remote peer, we may interator all list of URL with low efficence because  URL as the core model of dubbo is a level of peer remote. So we need a service level model like this.

## Brief changelog

A new pojo class is suggested to import.


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3078 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org


[GitHub] [incubator-dubbo] chickenlj closed pull request #3078: import a pojo ServiceMeta which is used as service level info and a addressListener to extends

Posted by "chickenlj (GitHub)" <gi...@apache.org>.
[ pull request closed by chickenlj ]

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3078 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org


[GitHub] [incubator-dubbo] ralf0131 commented on pull request #3078: import a pojo ServiceMeta which is used as service level info and a addressListener to extends

Posted by "ralf0131 (GitHub)" <gi...@apache.org>.
License info should appear first.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3078 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org


[GitHub] [incubator-dubbo] chickenlj commented on issue #3078: import a pojo ServiceMeta which is used as service level info and a addressListener to extends

Posted by "chickenlj (GitHub)" <gi...@apache.org>.
URL is one core concept in Dubbo.
I agree with the defects you mentioned about the URL mechanism and I understand the benefits 
 `ServiceMetadata` can bring. But I think it's a big step which will result in massive refactor that should be considered as a whole with what Ian has proposed about 3.0 on the mailing list.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3078 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org


[GitHub] [incubator-dubbo] chickenlj commented on issue #3078: import a pojo ServiceMeta which is used as service level info and a addressListener to extends

Posted by "chickenlj (GitHub)" <gi...@apache.org>.
I think this patch should be merged after the release of 2.7.0.

Or maybe it's time to create a separate branch for v2.7.0 to avoid blocking the master now.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3078 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org