You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@jmeter.apache.org by Philippe Mouawad <ph...@gmail.com> on 2015/12/09 23:17:23 UTC

What about releasing a 2.14 ?

Hello,
We have a quite rich version now I think (more than 50 bugs/enhancements+ 2
major features) , what about releasing a new version ?

Regards
Philippe M.



-- 
Cordialement.
Philippe Mouawad.

Re: What about releasing a 2.14 ?

Posted by Philippe Mouawad <ph...@gmail.com>.

Hi Rainer,
It appears you're very busy.

Anybody had a chance to test and review code ?

Thanks

On Wednesday, January 6, 2016, Philippe Mouawad <ph...@gmail.com>
wrote:

> Hi Rainer,
> Did you have time to test ?
> Thanks
>
> On Tue, Dec 29, 2015 at 11:48 AM, Rainer Jung <rainer.jung@kippdata.de
> <javascript:_e(%7B%7D,'cvml','rainer.jung@kippdata.de');>> wrote:
>
>> I hope later today.
>>
>> Thanks for the fix in any case!
>>
>> Regards,
>>
>> Rainer
>>
>>
>> Am 29.12.2015 um 09:24 schrieb Philippe Mouawad:
>>
>>> Hi Rainer, all,
>>> Anybody had a chance to review and test code ?
>>>
>>> Thx
>>>
>>> On Sunday, December 27, 2015, Philippe Mouawad <
>>> philippe.mouawad@gmail.com
>>> <javascript:_e(%7B%7D,'cvml','philippe.mouawad@gmail.com');>>
>>> wrote:
>>>
>>> Hi Rainer,
>>>> I think I fixed with  Revision: 1721771 the bug
>>>> https://bz.apache.org/bugzilla/show_bug.cgi?id=57804.
>>>> Could you have a look and test.
>>>>
>>>> Beside this, I notice a change in the logs in the NoClientCert test case
>>>> attached between 2.13 and 2.14, I cannot tell if it's a bug or regular.
>>>>
>>>> If you compare nohup-2.14-pre-commit-1721771-no-client-cert.log with
>>>> nohup-2.13-no-client-cert.log.
>>>>
>>>> With 2.13 I see only 1 time => *** ClientHello, TLSv1
>>>> With 2.14 I see 4 times => *** ClientHello, TLSv1, but preceded the 3
>>>> last
>>>> times with => %% Try resuming [Session-1,
>>>> TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA] from port 2571
>>>>
>>>> Regards
>>>> Philippe M.
>>>> @philmdot
>>>>
>>>
>
>
> --
> Cordialement.
> Philippe Mouawad.
>
>
>

-- 
Cordialement.
Philippe Mouawad.

Re: What about releasing a 2.14 ?

Posted by Philippe Mouawad <ph...@gmail.com>.

Hi Rainer,
Did you have time to test ?
Thanks

On Tue, Dec 29, 2015 at 11:48 AM, Rainer Jung <ra...@kippdata.de>
wrote:

> I hope later today.
>
> Thanks for the fix in any case!
>
> Regards,
>
> Rainer
>
>
> Am 29.12.2015 um 09:24 schrieb Philippe Mouawad:
>
>> Hi Rainer, all,
>> Anybody had a chance to review and test code ?
>>
>> Thx
>>
>> On Sunday, December 27, 2015, Philippe Mouawad <
>> philippe.mouawad@gmail.com>
>> wrote:
>>
>> Hi Rainer,
>>> I think I fixed with  Revision: 1721771 the bug
>>> https://bz.apache.org/bugzilla/show_bug.cgi?id=57804.
>>> Could you have a look and test.
>>>
>>> Beside this, I notice a change in the logs in the NoClientCert test case
>>> attached between 2.13 and 2.14, I cannot tell if it's a bug or regular.
>>>
>>> If you compare nohup-2.14-pre-commit-1721771-no-client-cert.log with
>>> nohup-2.13-no-client-cert.log.
>>>
>>> With 2.13 I see only 1 time => *** ClientHello, TLSv1
>>> With 2.14 I see 4 times => *** ClientHello, TLSv1, but preceded the 3
>>> last
>>> times with => %% Try resuming [Session-1,
>>> TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA] from port 2571
>>>
>>> Regards
>>> Philippe M.
>>> @philmdot
>>>
>>


-- 
Cordialement.
Philippe Mouawad.

Re: What about releasing a 2.14 ?

Posted by Rainer Jung <ra...@kippdata.de>.

I hope later today.

Thanks for the fix in any case!

Regards,

Rainer

Am 29.12.2015 um 09:24 schrieb Philippe Mouawad:
> Hi Rainer, all,
> Anybody had a chance to review and test code ?
>
> Thx
>
> On Sunday, December 27, 2015, Philippe Mouawad <ph...@gmail.com>
> wrote:
>
>> Hi Rainer,
>> I think I fixed with  Revision: 1721771 the bug
>> https://bz.apache.org/bugzilla/show_bug.cgi?id=57804.
>> Could you have a look and test.
>>
>> Beside this, I notice a change in the logs in the NoClientCert test case
>> attached between 2.13 and 2.14, I cannot tell if it's a bug or regular.
>>
>> If you compare nohup-2.14-pre-commit-1721771-no-client-cert.log with
>> nohup-2.13-no-client-cert.log.
>>
>> With 2.13 I see only 1 time => *** ClientHello, TLSv1
>> With 2.14 I see 4 times => *** ClientHello, TLSv1, but preceded the 3 last
>> times with => %% Try resuming [Session-1,
>> TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA] from port 2571
>>
>> Regards
>> Philippe M.
>> @philmdot

Re: What about releasing a 2.14 ?

Posted by Philippe Mouawad <ph...@gmail.com>.

Hi Rainer, all,
Anybody had a chance to review and test code ?

Thx

On Sunday, December 27, 2015, Philippe Mouawad <ph...@gmail.com>
wrote:

> Hi Rainer,
> I think I fixed with  Revision: 1721771 the bug
> https://bz.apache.org/bugzilla/show_bug.cgi?id=57804.
> Could you have a look and test.
>
> Beside this, I notice a change in the logs in the NoClientCert test case
> attached between 2.13 and 2.14, I cannot tell if it's a bug or regular.
>
> If you compare nohup-2.14-pre-commit-1721771-no-client-cert.log with
> nohup-2.13-no-client-cert.log.
>
> With 2.13 I see only 1 time => *** ClientHello, TLSv1
> With 2.14 I see 4 times => *** ClientHello, TLSv1, but preceded the 3 last
> times with => %% Try resuming [Session-1,
> TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA] from port 2571
>
> Regards
> Philippe M.
> @philmdot
>
> On Fri, Dec 18, 2015 at 12:27 AM, Philippe Mouawad <
> philippe.mouawad@gmail.com
> <javascript:_e(%7B%7D,'cvml','philippe.mouawad@gmail.com');>> wrote:
>
>> Hi Rainer,
>> Why not ask on httpclient user mailing list?
>> Regards
>>
>>
>> On Thursday, December 10, 2015, Rainer Jung <rainer.jung@kippdata.de
>> <javascript:_e(%7B%7D,'cvml','rainer.jung@kippdata.de');>> wrote:
>>
>>> Am 09.12.2015 um 23:17 schrieb Philippe Mouawad:
>>>
>>>> Hello,
>>>> We have a quite rich version now I think (more than 50
>>>> bugs/enhancements+ 2
>>>> major features) , what about releasing a new version ?
>>>>
>>>
>>> I ran into 57804 which is unfixed. It is about JMeter not reusing the
>>> SSL context if client certs are used. I don't know how to fix and client
>>> cert usage is not that common, but if you get hit by this, the highly
>>> increased handshake rate often kills your cpu resources. I had a look at it
>>> a few months ago, but the fix wasn't obvious to me. Any ideas around here?
>>>
>>> Regards,
>>>
>>> Rainer
>>>
>>>
>>

-- 
Cordialement.
Philippe Mouawad.

Re: What about releasing a 2.14 ?

Posted by Philippe Mouawad <ph...@gmail.com>.

Hi Rainer,
I think I fixed with  Revision: 1721771 the bug
https://bz.apache.org/bugzilla/show_bug.cgi?id=57804.
Could you have a look and test.

Beside this, I notice a change in the logs in the NoClientCert test case
attached between 2.13 and 2.14, I cannot tell if it's a bug or regular.

If you compare nohup-2.14-pre-commit-1721771-no-client-cert.log with
nohup-2.13-no-client-cert.log.

With 2.13 I see only 1 time => *** ClientHello, TLSv1
With 2.14 I see 4 times => *** ClientHello, TLSv1, but preceded the 3 last
times with => %% Try resuming [Session-1,
TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA] from port 2571

Regards
Philippe M.
@philmdot

On Fri, Dec 18, 2015 at 12:27 AM, Philippe Mouawad <
philippe.mouawad@gmail.com> wrote:

> Hi Rainer,
> Why not ask on httpclient user mailing list?
> Regards
>
>
> On Thursday, December 10, 2015, Rainer Jung <ra...@kippdata.de>
> wrote:
>
>> Am 09.12.2015 um 23:17 schrieb Philippe Mouawad:
>>
>>> Hello,
>>> We have a quite rich version now I think (more than 50
>>> bugs/enhancements+ 2
>>> major features) , what about releasing a new version ?
>>>
>>
>> I ran into 57804 which is unfixed. It is about JMeter not reusing the SSL
>> context if client certs are used. I don't know how to fix and client cert
>> usage is not that common, but if you get hit by this, the highly increased
>> handshake rate often kills your cpu resources. I had a look at it a few
>> months ago, but the fix wasn't obvious to me. Any ideas around here?
>>
>> Regards,
>>
>> Rainer
>>
>>
>

Re: What about releasing a 2.14 ?

Posted by Philippe Mouawad <ph...@gmail.com>.

Hi Rainer,
Why not ask on httpclient user mailing list?
Regards

On Thursday, December 10, 2015, Rainer Jung <ra...@kippdata.de> wrote:

> Am 09.12.2015 um 23:17 schrieb Philippe Mouawad:
>
>> Hello,
>> We have a quite rich version now I think (more than 50 bugs/enhancements+
>> 2
>> major features) , what about releasing a new version ?
>>
>
> I ran into 57804 which is unfixed. It is about JMeter not reusing the SSL
> context if client certs are used. I don't know how to fix and client cert
> usage is not that common, but if you get hit by this, the highly increased
> handshake rate often kills your cpu resources. I had a look at it a few
> months ago, but the fix wasn't obvious to me. Any ideas around here?
>
> Regards,
>
> Rainer
>
>

-- 
Cordialement.
Philippe Mouawad.

Re: What about releasing a 2.14 ?

Posted by Rainer Jung <ra...@kippdata.de>.

Am 09.12.2015 um 23:17 schrieb Philippe Mouawad:
> Hello,
> We have a quite rich version now I think (more than 50 bugs/enhancements+ 2
> major features) , what about releasing a new version ?

I ran into 57804 which is unfixed. It is about JMeter not reusing the 
SSL context if client certs are used. I don't know how to fix and client 
cert usage is not that common, but if you get hit by this, the highly 
increased handshake rate often kills your cpu resources. I had a look at 
it a few months ago, but the fix wasn't obvious to me. Any ideas around 
here?

Regards,

Rainer

Re: What about releasing a 2.14 ?

Posted by sebb <se...@gmail.com>.

On 10 December 2015 at 06:42, Philippe Mouawad
<ph...@gmail.com> wrote:
> On Wednesday, December 9, 2015, sebb <sebbaz@gmail.com
> <javascript:_e(%7B%7D,'cvml','sebbaz@gmail.com');>> wrote:
>
>> On 9 December 2015 at 22:17, Philippe Mouawad
>> <ph...@gmail.com> wrote:
>> > Hello,
>> > We have a quite rich version now I think (more than 50
>> bugs/enhancements+ 2
>> > major features) , what about releasing a new version ?
>>
>> Potentially, but there is still a lot to do to tidy up the recent
>> additions.
>>
>> * tabs/indentation issues, which don't affect behaviour, but are
>> tedious to fix, and cause maintenance issues
>> * implicit boxing/unboxing - I'm sure there are some NPEs lurking
>> here, not just the one I already reported
>
> I will have a look
>
>>
>> Plus:
>> * were the HC4 issues sorted? Is the code using the current HC release?
>
> I sent a detailed mail on this.
> There are existing failing tests with2.13 and hc4.2.3
> When you upgrade to 4.5.1 2 additional failures appear even after migrating
> CookieHandler.
> I suspect hc4.5 bug plus but we will also have to abandon existing cookie
> policies which are nearly all deprected.
>
> Oleg wants a pure hc Unit test to investigate issues.
>
> * there's the code I worked on earlier to support SampleTimeouts. I
>> think that's ready to be merged, but it has been waiting a while so it
>> may require some work.
>
> It is ok for me to merge it, but as I said we should avoid creating 1
> additional thread per thread for this feature. It would be better to

As I already explained, it does not create an extra thread per thread
in normal running.

There is one shared extra thread to handle the timeouts.
And  there is an option to use CALL instead of a new Runnable when the
timeout occurs.

With the Runnable option, extra threads are only created when a
timeout occurs, and of course only last for as long as necessary to
interrupt the sampler.

Even with lots of hung threads, it's very unlikely that they will all
timeout at the exactly the same time.

> register a timeouter using something like hashweeltimer and a timeout
> manager.

No idea what a hashweeltimer is, but I think this is effectively what it does.

> The current implementation reduces JMeter scalability per machine.

It shouldn't make a material difference.
Though of course any additional code that is loaded will use memory
and may have some effect.

> But as it is not mandatory to use it is ok for me.

OK, I will have a look at merging it.

>>
>> > Regards
>> > Philippe M.
>> >
>> >
>> >
>> > --
>> > Cordialement.
>> > Philippe Mouawad.
>>
>
>
> --
> Cordialement.
> Philippe Mouawad.