You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org> on 2010/05/20 12:58:53 UTC
[jira] Created: (QPID-2622) Closing ApplicationRegistry components
can NPE and prevent others cleanly shutting down
Closing ApplicationRegistry components can NPE and prevent others cleanly shutting down
---------------------------------------------------------------------------------------
Key: QPID-2622
URL: https://issues.apache.org/jira/browse/QPID-2622
Project: Qpid
Issue Type: Bug
Components: Java Broker
Affects Versions: 0.6, 0.5
Reporter: Martin Ritchie
Assignee: Martin Ritchie
The ApplicationRegistry has a close() method that peforms close() on a number of broker components.
However, it currently has a rather ugly structure:
try : close finally : try : close : finally ....
Also the items that are being closed need to be null tested in case there was an error during broker startup.
Refactor all the close methods so that they do not throw Exceptions as there is nothing we can do but report it during shutdown.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2622) Closing ApplicationRegistry components
can NPE and prevent others cleanly shutting down
Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Ritchie updated QPID-2622:
---------------------------------
Description:
The ApplicationRegistry has a close() method that peforms close() on a number of broker components.
However, it currently has a rather ugly structure:
try : close finally : try : close : finally ....
Also the items that are being closed need to be null tested in case there was an error during broker startup.
Refactor all the close methods so that they do not throw Exceptions as there is nothing we can do but report it during shutdown.
This is particularly annoying as QpidTestCase runs will fail and hide the true cause of the failure.
was:
The ApplicationRegistry has a close() method that peforms close() on a number of broker components.
However, it currently has a rather ugly structure:
try : close finally : try : close : finally ....
Also the items that are being closed need to be null tested in case there was an error during broker startup.
Refactor all the close methods so that they do not throw Exceptions as there is nothing we can do but report it during shutdown.
Component/s: Java Tests
> Closing ApplicationRegistry components can NPE and prevent others cleanly shutting down
> ---------------------------------------------------------------------------------------
>
> Key: QPID-2622
> URL: https://issues.apache.org/jira/browse/QPID-2622
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker, Java Tests
> Affects Versions: 0.5, 0.6
> Reporter: Martin Ritchie
> Assignee: Martin Ritchie
>
> The ApplicationRegistry has a close() method that peforms close() on a number of broker components.
> However, it currently has a rather ugly structure:
> try : close finally : try : close : finally ....
> Also the items that are being closed need to be null tested in case there was an error during broker startup.
> Refactor all the close methods so that they do not throw Exceptions as there is nothing we can do but report it during shutdown.
> This is particularly annoying as QpidTestCase runs will fail and hide the true cause of the failure.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org