[GitHub] [airflow] o-nikolas commented on a diff in pull request #27134: Add info about JSON Connection format for AWS SSM Parameter Store Secrets Backend

[GitBox <gi...@apache.org>]

o-nikolas commented on code in PR #27134:
URL: https://github.com/apache/airflow/pull/27134#discussion_r1005208001


##########
docs/apache-airflow-providers-amazon/secrets-backends/aws-ssm-parameter-store.rst:
##########
@@ -67,9 +67,10 @@ you would want to store your connection at ``/airflow/connections/smtp_default``
 Optionally you can supply a profile name to reference aws profile, e.g. defined in ``~/.aws/config``.
 
 The value of the SSM parameter must be the :ref:`connection URI representation <generating_connection_uri>`
-of the connection object.
+or in the :ref:`JSON Format <connection-serialization-json-example>` of the connection object.
 
-In some cases, URI's you will need stored in Secrets Manager may not be intuitive, for example when using HTTP / HTTPS or SPARK, you may need URI's that will look like this:
+In some cases, URI's you will need stored in AWS SSM Parameter Store may not be intuitive,
+for example when using HTTP / HTTPS or SPARK, you may need URI's that will look like this:

Review Comment:
   Regarding the above thread, I think it's the use of past tense that makes it read oddly? What about this minor change: 
   ```suggestion
   In some cases, URI's that you will need to store in AWS SSM Parameter Store may not be intuitive,
   for example when using HTTP / HTTPS or SPARK, you may need URI's that will look like this:
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org