You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2018/03/01 02:31:51 UTC
Re: Review Request 65780: Removed an unnecessary argument from
master::Call validation.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65780/
-----------------------------------------------------------
(Updated March 1, 2018, 2:31 a.m.)
Review request for mesos, Michael Park and Meng Zhu.
Changes
-------
Update dependency.
Repository: mesos
Description
-------
The principal is not needed by the validation function.
Diffs (updated)
-----
src/master/http.cpp acf10a0f396234ec9f444c9b41515d657379d6ad
src/master/validation.hpp 7c129ceb929596acbb64d37025e055661277e6bf
src/master/validation.cpp 9254cd22e67d9aca53135701575fb0857ff6f7d6
Diff: https://reviews.apache.org/r/65780/diff/2/
Changes: https://reviews.apache.org/r/65780/diff/1-2/
Testing
-------
make check
Thanks,
Benjamin Mahler
Re: Review Request 65780: Removed an unnecessary argument from
master::Call validation.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65780/#review198843
-----------------------------------------------------------
Ship it!
Ship It!
- Meng Zhu
On Feb. 28, 2018, 6:31 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65780/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2018, 6:31 p.m.)
>
>
> Review request for mesos, Michael Park and Meng Zhu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The principal is not needed by the validation function.
>
>
> Diffs
> -----
>
> src/master/http.cpp acf10a0f396234ec9f444c9b41515d657379d6ad
> src/master/validation.hpp 7c129ceb929596acbb64d37025e055661277e6bf
> src/master/validation.cpp 9254cd22e67d9aca53135701575fb0857ff6f7d6
>
>
> Diff: https://reviews.apache.org/r/65780/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>