You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by mgaido91 <gi...@git.apache.org> on 2018/05/15 11:03:46 UTC

[GitHub] spark pull request #21109: [SPARK-24020][SQL] Sort-merge join inner range op...

Github user mgaido91 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21109#discussion_r188240094
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala ---
    @@ -131,13 +134,101 @@ object ExtractEquiJoinKeys extends Logging with PredicateHelper {
     
           if (joinKeys.nonEmpty) {
             val (leftKeys, rightKeys) = joinKeys.unzip
    -        logDebug(s"leftKeys:$leftKeys | rightKeys:$rightKeys")
    -        Some((joinType, leftKeys, rightKeys, otherPredicates.reduceOption(And), left, right))
    +
    --- End diff --
    
    nit: unnecessary empty line


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org