You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by appzer <gi...@git.apache.org> on 2016/11/18 19:23:49 UTC
[GitHub] cordova-plugin-device pull request #57: add device name for iOS
GitHub user appzer opened a pull request:
https://github.com/apache/cordova-plugin-device/pull/57
add device name for iOS
### Platforms affected
iOS
### What does this PR do?
add device name for iOS
### What testing has been done on this change?
### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/appzer/cordova-plugin-device master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-device/pull/57.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #57
----
commit ff7644b5eef1582f4e147f48f75faf19eb9817de
Author: Kevin <ap...@users.noreply.github.com>
Date: 2016-11-18T19:20:35Z
Update CDVDevice.m
add device name
commit d88ba9a193afe971bf983b9b7f9a84a811bd7be7
Author: Kevin <ap...@users.noreply.github.com>
Date: 2016-11-18T19:22:17Z
Update device.js
add device name for iOS
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-device issue #57: add device name for iOS
Posted by pke <gi...@git.apache.org>.
Github user pke commented on the issue:
https://github.com/apache/cordova-plugin-device/pull/57
But that is not the name the user gave the device, is it?
The `name` property has been deprecated here before. I think this PR is not complete without readme changes and implementations for Windows and Android.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-device issue #57: add device name for iOS
Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on the issue:
https://github.com/apache/cordova-plugin-device/pull/57
Agree with @pke. Close 57
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org