[GitHub] [iceberg] dimas-b commented on pull request #5190: [API] Fix ErrorProne warnings in API module

[GitBox <gi...@apache.org>]

dimas-b commented on PR #5190:
URL: https://github.com/apache/iceberg/pull/5190#issuecomment-1173790084

   Re: https://github.com/apache/iceberg/blob/master/api/src/main/java/org/apache/iceberg/util/ExceptionUtil.java#L124 it does look like the most recent exception (`e` in code) is lost. 
   
   Perhaps that line should do `throw new RuntimeException("Unknown exception in finally block", e)` (since `failure` is certainly `null` there).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org