You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "OmriSteiner (via GitHub)" <gi...@apache.org> on 2025/05/09 10:17:34 UTC
[PR] fix: treat TCP reset as a retryable error [arrow-rs-object-store]
OmriSteiner opened a new pull request, #351:
URL: https://github.com/apache/arrow-rs-object-store/pull/351
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #350.
# Rationale for this change
We want object_store to retry the request in case the connection closed abruptly.
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
Map `std::io::ErrorKind::ConnectionReset` -> `HttpErrorKind::Interrupted`
# Are there any user-facing changes?
No.
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please call them out.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: treat TCP reset as a retryable error [arrow-rs-object-store]
Posted by "berkaysynnada (via GitHub)" <gi...@apache.org>.
berkaysynnada commented on PR #351:
URL: https://github.com/apache/arrow-rs-object-store/pull/351#issuecomment-2871153206
Failure on the main is related with this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: treat TCP reset as a retryable error [arrow-rs-object-store]
Posted by "OmriSteiner (via GitHub)" <gi...@apache.org>.
OmriSteiner commented on PR #351:
URL: https://github.com/apache/arrow-rs-object-store/pull/351#issuecomment-2871234343
> Failure on the main is related with this?
That same test passed on this branch.
The only reason I can think of is that statistically the delete request in the test fails - and this change causes it to both (!):
* Not retry
* Not fail the request
I can get behind not retry - maybe there was an error which was previously mapped to `Timeout` / `Connect` / `Decode` and now it is mapped to `Interrupted` - which is retried in case the request is not idempotent (delete isn't).
But I would expect the test to panic at `src/integration.rs:955` because the request fails.
-----------------------
To be fair, it's possible that TCP-RST on connect actually caused this to convert `Connect` errors to `Interrupted` errors.
WDYT about only doing the error refinement in case `kind == Unknown`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: treat TCP reset as a retryable error [arrow-rs-object-store]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #351:
URL: https://github.com/apache/arrow-rs-object-store/pull/351#issuecomment-2871473566
I think it is just a flaky test unrelated to this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: treat TCP reset as a retryable error [arrow-rs-object-store]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold merged PR #351:
URL: https://github.com/apache/arrow-rs-object-store/pull/351
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org