You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Nigel Daley (JIRA)" <ji...@apache.org> on 2007/04/13 23:07:15 UTC
[jira] Created: (HADOOP-1260) need code review guidelines
need code review guidelines
---------------------------
Key: HADOOP-1260
URL: https://issues.apache.org/jira/browse/HADOOP-1260
Project: Hadoop
Issue Type: Improvement
Components: build
Reporter: Nigel Daley
Following the improvements to the Hadoop release process (HADOOP-1161), it would be helpful to better document what a code review should entail. I've posted a proposal here (not yet linked to from anywhere):
http://wiki.apache.org/lucene-hadoop/CodeReviewChecklist
Thoughts?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HADOOP-1260) need code review guidelines
Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nigel Daley resolved HADOOP-1260.
---------------------------------
Resolution: Fixed
Fix Version/s: 0.13.0
Assignee: Nigel Daley
Done. http://wiki.apache.org/lucene-hadoop/HowToContribute has been updated with:
- a link to the code review checklist, and
- added a statement of benchmarking optomizations.
> need code review guidelines
> ---------------------------
>
> Key: HADOOP-1260
> URL: https://issues.apache.org/jira/browse/HADOOP-1260
> Project: Hadoop
> Issue Type: Improvement
> Components: build
> Reporter: Nigel Daley
> Assigned To: Nigel Daley
> Fix For: 0.13.0
>
>
> Following the improvements to the Hadoop release process (HADOOP-1161), it would be helpful to better document what a code review should entail. I've posted a proposal here (not yet linked to from anywhere):
> http://wiki.apache.org/lucene-hadoop/CodeReviewChecklist
> Thoughts?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1260) need code review guidelines
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489492 ]
Doug Cutting commented on HADOOP-1260:
--------------------------------------
We should note either here or on the HowToContribute page that performance optimizations should be validated by benchmarks.
> need code review guidelines
> ---------------------------
>
> Key: HADOOP-1260
> URL: https://issues.apache.org/jira/browse/HADOOP-1260
> Project: Hadoop
> Issue Type: Improvement
> Components: build
> Reporter: Nigel Daley
>
> Following the improvements to the Hadoop release process (HADOOP-1161), it would be helpful to better document what a code review should entail. I've posted a proposal here (not yet linked to from anywhere):
> http://wiki.apache.org/lucene-hadoop/CodeReviewChecklist
> Thoughts?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1260) need code review guidelines
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489218 ]
Doug Cutting commented on HADOOP-1260:
--------------------------------------
These look good to me. +1
> need code review guidelines
> ---------------------------
>
> Key: HADOOP-1260
> URL: https://issues.apache.org/jira/browse/HADOOP-1260
> Project: Hadoop
> Issue Type: Improvement
> Components: build
> Reporter: Nigel Daley
>
> Following the improvements to the Hadoop release process (HADOOP-1161), it would be helpful to better document what a code review should entail. I've posted a proposal here (not yet linked to from anywhere):
> http://wiki.apache.org/lucene-hadoop/CodeReviewChecklist
> Thoughts?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (HADOOP-1260) need code review guidelines
Posted by Doug Cutting <cu...@apache.org>.
Nigel Daley wrote:
> Should a +1 code review comment be required
> a) before "Submit Patch"
> b) after "Submit Patch"
> c) either before or after ?
I'd vote for (c). Setting something to "Submit Patch" is a good way to
request a review. But if someone posts a speculative patch that they're
not yet comfortable marking "Patch Available", and someone reviews it,
that's okay too. The final review is always the responsibility of the
committer who commits it. Other reviews are advisory. And of course,
committers shouldn't be the sole reviewers of their own patches.
Doug
Re: [jira] Commented: (HADOOP-1260) need code review guidelines
Posted by Nigel Daley <nd...@yahoo-inc.com>.
Ok, I'll link them off of
http://wiki.apache.org/lucene-hadoop/HowToContribute
and close this issue.
Should a +1 code review comment be required
a) before "Submit Patch"
b) after "Submit Patch"
c) either before or after ?
On Apr 16, 2007, at 1:31 PM, Tom White (JIRA) wrote:
>
> [ https://issues.apache.org/jira/browse/HADOOP-1260?
> page=com.atlassian.jira.plugin.system.issuetabpanels:comment-
> tabpanel#action_12489223 ]
>
> Tom White commented on HADOOP-1260:
> -----------------------------------
>
> +1
>
>> need code review guidelines
>> ---------------------------
>>
>> Key: HADOOP-1260
>> URL: https://issues.apache.org/jira/browse/
>> HADOOP-1260
>> Project: Hadoop
>> Issue Type: Improvement
>> Components: build
>> Reporter: Nigel Daley
>>
>> Following the improvements to the Hadoop release process
>> (HADOOP-1161), it would be helpful to better document what a code
>> review should entail. I've posted a proposal here (not yet linked
>> to from anywhere):
>> http://wiki.apache.org/lucene-hadoop/CodeReviewChecklist
>> Thoughts?
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
[jira] Commented: (HADOOP-1260) need code review guidelines
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489223 ]
Tom White commented on HADOOP-1260:
-----------------------------------
+1
> need code review guidelines
> ---------------------------
>
> Key: HADOOP-1260
> URL: https://issues.apache.org/jira/browse/HADOOP-1260
> Project: Hadoop
> Issue Type: Improvement
> Components: build
> Reporter: Nigel Daley
>
> Following the improvements to the Hadoop release process (HADOOP-1161), it would be helpful to better document what a code review should entail. I've posted a proposal here (not yet linked to from anywhere):
> http://wiki.apache.org/lucene-hadoop/CodeReviewChecklist
> Thoughts?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1260) need code review guidelines
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489473 ]
Owen O'Malley commented on HADOOP-1260:
---------------------------------------
+1
> need code review guidelines
> ---------------------------
>
> Key: HADOOP-1260
> URL: https://issues.apache.org/jira/browse/HADOOP-1260
> Project: Hadoop
> Issue Type: Improvement
> Components: build
> Reporter: Nigel Daley
>
> Following the improvements to the Hadoop release process (HADOOP-1161), it would be helpful to better document what a code review should entail. I've posted a proposal here (not yet linked to from anywhere):
> http://wiki.apache.org/lucene-hadoop/CodeReviewChecklist
> Thoughts?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.