[jira] Closed: (WAGONSSH-17) ssh command executor exits too fast sometimes.

["Brett Porter (JIRA)" <ji...@codehaus.org>]

     [ http://jira.codehaus.org/browse/WAGONSSH-17?page=all ]
     
Brett Porter closed WAGONSSH-17:
--------------------------------

    Resolution: Fixed

rewrote the ScpWagon to do better error handling

> ssh command executor exits too fast sometimes.
> ----------------------------------------------
>
>          Key: WAGONSSH-17
>          URL: http://jira.codehaus.org/browse/WAGONSSH-17
>      Project: wagon-ssh
>         Type: Bug
>     Versions: 1.0-alpha-5
>  Environment: maven running on win2k3 deploying to Red Hat linux kernel 2.6.9.
>     Reporter: md
>     Assignee: Brett Porter
>     Priority: Blocker
>      Fix For: 1.0-alpha-5
>  Attachments: ScpWagon.java
>
>
> I am creating this new issue since i don't have permissions to re-open MNG-476
> I created a plaing vanilla project and tried to deploy to my repository. I did not see the site files deployed to the repository.
> Looking at the code, I noticed 3 problems:
> 1. The commands to create the directories has extra slashes. This caused problems with file uploads.
> In ScpWagon.java, line 264: While initializing the mkdirCmd, the code should check if basedir endsWith a trailing '/' before appending another one. I have attached the file since i i am not sure of the fix. There are other places in the code, but this one fixed my problem :-).
> 2. Maven returns too early while executing the unzip command. My hack was a Thread.sleep(200) call right after the 
> channel.connect();
> call in ScpWagon.executeCommand. This is less than ideal. It should be deterministic.
> 3. The unzip command does not capture the error output stream. It should be:
> cmd = " cd " + basedir + ";" + unzipCommand + " " + zipFile.getName() + " >scpdeploymojo.log 2>&1";
> in line 156 of ScpSiteDeployMojo.java. I am not sure if this last item should be in a separate defect. Let me know and I will create another one.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: wagon-dev-unsubscribe@maven.apache.org
For additional commands, e-mail: wagon-dev-help@maven.apache.org