You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "Caideyipi (via GitHub)" <gi...@apache.org> on 2026/08/07 09:25:13 UTC

Re: [PR] Fix aggregation NPE when child input finishes early [iotdb]

Caideyipi commented on PR #18171:
URL: https://github.com/apache/iotdb/pull/18171#issuecomment-5215272988

   Thanks for the deeper follow-up. I addressed the concrete reachability gap in 0d8c239cb91: AbstractConsumeAllOperator now clears inputTsBlocks when a child finishes, so a zero-row block cannot remain as a non-null finished-child slot. I added testGroupByIntermediateResultWithFinishedEmptyChild with a deterministic empty child and verified the remaining child aggregate is still produced. This also protects the sibling consume-all operators that share the base implementation. I left the tsBlockIndex assertion and broader sibling-specific tests out of this focused fix; the existing null guards remain valid once the base slot invariant is restored.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org