[GitHub] spark pull request #13712: [SPARK-15990][YARN] Add rolling log aggregation s...

[srowen <gi...@git.apache.org>]

Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13712#discussion_r99353603
  
    --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
    @@ -271,6 +271,33 @@ private[spark] class Client(
             appContext.setResource(capability)
         }
     
    +    sparkConf.get(ROLLED_LOG_INCLUDE_PATTERN).foreach { includePattern =>
    --- End diff --
    
    @jerryshao  on this old commit -- am I right that this outer foreach is not supposed to include all of the rest of the body here? it looks like for each include pattern, it will process all exclude patterns, and set the context again. are these supposed to be two separate loops or did I miss the point?
    
    No worries if so, I may be able to change this if needed while making changes for 2.6.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org