You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Sergio Pena via Review Board <no...@reviews.apache.org> on 2018/05/01 20:30:33 UTC
Review Request 66890: HIVE-19371: Add table ownerType to HMS thrift
API
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66890/
-----------------------------------------------------------
Review request for hive, Alexander Kolbasov, Sahil Takiar, and Vihang Karajgaonkar.
Bugs: HIVE-19371
https://issues.apache.org/jira/browse/HIVE-19371
Repository: hive-git
Description
-------
This is a subtask part of 'HIVE-18762 Support ALTER TABLE SET OWNER command' which adds a new ownerType field on the Table object of the Thrift API of HMS.
The only file updated (before generting the thrift code) is:
- hive_metastore.thrift
The new field is added as 'optional' at the end of the 'struct Table' in order to be backward compatible with older clients of HMS.
The ownerType filed will be set to a USER as the default value as current tables created are using the owner name as the user.
Diffs
-----
standalone-metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 47877034746a1cf81cc6731bedb8a6da9cee5b6d
standalone-metastore/src/gen/thrift/gen-cpp/hive_metastore_types.h 629889389e29dcbf9802c348f3b73f6c65695f6f
standalone-metastore/src/gen/thrift/gen-cpp/hive_metastore_types.cpp c6fadf8a24a32bb208ae6819f159b9b4d5301a2b
standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Table.java 8dfec980d9e14ad01fda27ad97e2e6a91846f782
standalone-metastore/src/gen/thrift/gen-php/metastore/Types.php 9f6cc0e871754afc4fcdbdfb0907d78a0298634c
standalone-metastore/src/gen/thrift/gen-py/hive_metastore/ttypes.py 69579e2f593d35c4d52ae7c81d5186d0ae3d379a
standalone-metastore/src/gen/thrift/gen-rb/hive_metastore_types.rb d7ebaaf914997371201a123f3fc28fac63464ce3
standalone-metastore/src/main/thrift/hive_metastore.thrift ccc3c93bcec88b96e524eeb6d47b7c77ccf49d34
Diff: https://reviews.apache.org/r/66890/diff/1/
Testing
-------
Waiting for Hive QA.
Thanks,
Sergio Pena
Re: Review Request 66890: HIVE-19371: Add table ownerType to HMS
thrift API
Posted by Vihang Karajgaonkar via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66890/#review202309
-----------------------------------------------------------
Ship it!
- Vihang Karajgaonkar
On May 1, 2018, 8:30 p.m., Sergio Pena wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66890/
> -----------------------------------------------------------
>
> (Updated May 1, 2018, 8:30 p.m.)
>
>
> Review request for hive, Alexander Kolbasov, Sahil Takiar, and Vihang Karajgaonkar.
>
>
> Bugs: HIVE-19371
> https://issues.apache.org/jira/browse/HIVE-19371
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> This is a subtask part of 'HIVE-18762 Support ALTER TABLE SET OWNER command' which adds a new ownerType field on the Table object of the Thrift API of HMS.
>
> The only file updated (before generting the thrift code) is:
> - hive_metastore.thrift
>
> The new field is added as 'optional' at the end of the 'struct Table' in order to be backward compatible with older clients of HMS.
> The ownerType filed will be set to a USER as the default value as current tables created are using the owner name as the user.
>
>
> Diffs
> -----
>
> standalone-metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 47877034746a1cf81cc6731bedb8a6da9cee5b6d
> standalone-metastore/src/gen/thrift/gen-cpp/hive_metastore_types.h 629889389e29dcbf9802c348f3b73f6c65695f6f
> standalone-metastore/src/gen/thrift/gen-cpp/hive_metastore_types.cpp c6fadf8a24a32bb208ae6819f159b9b4d5301a2b
> standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Table.java 8dfec980d9e14ad01fda27ad97e2e6a91846f782
> standalone-metastore/src/gen/thrift/gen-php/metastore/Types.php 9f6cc0e871754afc4fcdbdfb0907d78a0298634c
> standalone-metastore/src/gen/thrift/gen-py/hive_metastore/ttypes.py 69579e2f593d35c4d52ae7c81d5186d0ae3d379a
> standalone-metastore/src/gen/thrift/gen-rb/hive_metastore_types.rb d7ebaaf914997371201a123f3fc28fac63464ce3
> standalone-metastore/src/main/thrift/hive_metastore.thrift ccc3c93bcec88b96e524eeb6d47b7c77ccf49d34
>
>
> Diff: https://reviews.apache.org/r/66890/diff/1/
>
>
> Testing
> -------
>
> Waiting for Hive QA.
>
>
> Thanks,
>
> Sergio Pena
>
>
Re: Review Request 66890: HIVE-19371: Add table ownerType to HMS
thrift API
Posted by Sergio Pena via Review Board <no...@reviews.apache.org>.
> On May 2, 2018, 5:49 p.m., Vihang Karajgaonkar wrote:
> > standalone-metastore/src/gen/thrift/gen-rb/hive_metastore_types.rb
> > Lines 1071 (patched)
> > <https://reviews.apache.org/r/66890/diff/1/?file=2015459#file2015459line1071>
> >
> > Is it possible to write a test to make sure this works as expected?
This is Ruby on Rails code. I don't know how to create a test to verify Ruby.
Should we verify it?
Btw, there are other tests in a follow-up patch which implements this Thrift API on the ObjectStore.
See https://reviews.apache.org/r/66909/ (needs review too)
- Sergio
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66890/#review202291
-----------------------------------------------------------
On May 1, 2018, 8:30 p.m., Sergio Pena wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66890/
> -----------------------------------------------------------
>
> (Updated May 1, 2018, 8:30 p.m.)
>
>
> Review request for hive, Alexander Kolbasov, Sahil Takiar, and Vihang Karajgaonkar.
>
>
> Bugs: HIVE-19371
> https://issues.apache.org/jira/browse/HIVE-19371
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> This is a subtask part of 'HIVE-18762 Support ALTER TABLE SET OWNER command' which adds a new ownerType field on the Table object of the Thrift API of HMS.
>
> The only file updated (before generting the thrift code) is:
> - hive_metastore.thrift
>
> The new field is added as 'optional' at the end of the 'struct Table' in order to be backward compatible with older clients of HMS.
> The ownerType filed will be set to a USER as the default value as current tables created are using the owner name as the user.
>
>
> Diffs
> -----
>
> standalone-metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 47877034746a1cf81cc6731bedb8a6da9cee5b6d
> standalone-metastore/src/gen/thrift/gen-cpp/hive_metastore_types.h 629889389e29dcbf9802c348f3b73f6c65695f6f
> standalone-metastore/src/gen/thrift/gen-cpp/hive_metastore_types.cpp c6fadf8a24a32bb208ae6819f159b9b4d5301a2b
> standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Table.java 8dfec980d9e14ad01fda27ad97e2e6a91846f782
> standalone-metastore/src/gen/thrift/gen-php/metastore/Types.php 9f6cc0e871754afc4fcdbdfb0907d78a0298634c
> standalone-metastore/src/gen/thrift/gen-py/hive_metastore/ttypes.py 69579e2f593d35c4d52ae7c81d5186d0ae3d379a
> standalone-metastore/src/gen/thrift/gen-rb/hive_metastore_types.rb d7ebaaf914997371201a123f3fc28fac63464ce3
> standalone-metastore/src/main/thrift/hive_metastore.thrift ccc3c93bcec88b96e524eeb6d47b7c77ccf49d34
>
>
> Diff: https://reviews.apache.org/r/66890/diff/1/
>
>
> Testing
> -------
>
> Waiting for Hive QA.
>
>
> Thanks,
>
> Sergio Pena
>
>
Re: Review Request 66890: HIVE-19371: Add table ownerType to HMS
thrift API
Posted by Vihang Karajgaonkar via Review Board <no...@reviews.apache.org>.
> On May 2, 2018, 5:49 p.m., Vihang Karajgaonkar wrote:
> > standalone-metastore/src/gen/thrift/gen-rb/hive_metastore_types.rb
> > Lines 1071 (patched)
> > <https://reviews.apache.org/r/66890/diff/1/?file=2015459#file2015459line1071>
> >
> > Is it possible to write a test to make sure this works as expected?
>
> Sergio Pena wrote:
> This is Ruby on Rails code. I don't know how to create a test to verify Ruby.
> Should we verify it?
>
> Btw, there are other tests in a follow-up patch which implements this Thrift API on the ObjectStore.
>
> See https://reviews.apache.org/r/66909/ (needs review too)
Oh, this is in the auto-generated code. Sorry, I missed that. Dropping this comment.
- Vihang
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66890/#review202291
-----------------------------------------------------------
On May 1, 2018, 8:30 p.m., Sergio Pena wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66890/
> -----------------------------------------------------------
>
> (Updated May 1, 2018, 8:30 p.m.)
>
>
> Review request for hive, Alexander Kolbasov, Sahil Takiar, and Vihang Karajgaonkar.
>
>
> Bugs: HIVE-19371
> https://issues.apache.org/jira/browse/HIVE-19371
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> This is a subtask part of 'HIVE-18762 Support ALTER TABLE SET OWNER command' which adds a new ownerType field on the Table object of the Thrift API of HMS.
>
> The only file updated (before generting the thrift code) is:
> - hive_metastore.thrift
>
> The new field is added as 'optional' at the end of the 'struct Table' in order to be backward compatible with older clients of HMS.
> The ownerType filed will be set to a USER as the default value as current tables created are using the owner name as the user.
>
>
> Diffs
> -----
>
> standalone-metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 47877034746a1cf81cc6731bedb8a6da9cee5b6d
> standalone-metastore/src/gen/thrift/gen-cpp/hive_metastore_types.h 629889389e29dcbf9802c348f3b73f6c65695f6f
> standalone-metastore/src/gen/thrift/gen-cpp/hive_metastore_types.cpp c6fadf8a24a32bb208ae6819f159b9b4d5301a2b
> standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Table.java 8dfec980d9e14ad01fda27ad97e2e6a91846f782
> standalone-metastore/src/gen/thrift/gen-php/metastore/Types.php 9f6cc0e871754afc4fcdbdfb0907d78a0298634c
> standalone-metastore/src/gen/thrift/gen-py/hive_metastore/ttypes.py 69579e2f593d35c4d52ae7c81d5186d0ae3d379a
> standalone-metastore/src/gen/thrift/gen-rb/hive_metastore_types.rb d7ebaaf914997371201a123f3fc28fac63464ce3
> standalone-metastore/src/main/thrift/hive_metastore.thrift ccc3c93bcec88b96e524eeb6d47b7c77ccf49d34
>
>
> Diff: https://reviews.apache.org/r/66890/diff/1/
>
>
> Testing
> -------
>
> Waiting for Hive QA.
>
>
> Thanks,
>
> Sergio Pena
>
>
Re: Review Request 66890: HIVE-19371: Add table ownerType to HMS
thrift API
Posted by Vihang Karajgaonkar via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66890/#review202291
-----------------------------------------------------------
standalone-metastore/src/gen/thrift/gen-rb/hive_metastore_types.rb
Lines 1071 (patched)
<https://reviews.apache.org/r/66890/#comment284064>
Is it possible to write a test to make sure this works as expected?
- Vihang Karajgaonkar
On May 1, 2018, 8:30 p.m., Sergio Pena wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66890/
> -----------------------------------------------------------
>
> (Updated May 1, 2018, 8:30 p.m.)
>
>
> Review request for hive, Alexander Kolbasov, Sahil Takiar, and Vihang Karajgaonkar.
>
>
> Bugs: HIVE-19371
> https://issues.apache.org/jira/browse/HIVE-19371
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> This is a subtask part of 'HIVE-18762 Support ALTER TABLE SET OWNER command' which adds a new ownerType field on the Table object of the Thrift API of HMS.
>
> The only file updated (before generting the thrift code) is:
> - hive_metastore.thrift
>
> The new field is added as 'optional' at the end of the 'struct Table' in order to be backward compatible with older clients of HMS.
> The ownerType filed will be set to a USER as the default value as current tables created are using the owner name as the user.
>
>
> Diffs
> -----
>
> standalone-metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 47877034746a1cf81cc6731bedb8a6da9cee5b6d
> standalone-metastore/src/gen/thrift/gen-cpp/hive_metastore_types.h 629889389e29dcbf9802c348f3b73f6c65695f6f
> standalone-metastore/src/gen/thrift/gen-cpp/hive_metastore_types.cpp c6fadf8a24a32bb208ae6819f159b9b4d5301a2b
> standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Table.java 8dfec980d9e14ad01fda27ad97e2e6a91846f782
> standalone-metastore/src/gen/thrift/gen-php/metastore/Types.php 9f6cc0e871754afc4fcdbdfb0907d78a0298634c
> standalone-metastore/src/gen/thrift/gen-py/hive_metastore/ttypes.py 69579e2f593d35c4d52ae7c81d5186d0ae3d379a
> standalone-metastore/src/gen/thrift/gen-rb/hive_metastore_types.rb d7ebaaf914997371201a123f3fc28fac63464ce3
> standalone-metastore/src/main/thrift/hive_metastore.thrift ccc3c93bcec88b96e524eeb6d47b7c77ccf49d34
>
>
> Diff: https://reviews.apache.org/r/66890/diff/1/
>
>
> Testing
> -------
>
> Waiting for Hive QA.
>
>
> Thanks,
>
> Sergio Pena
>
>