You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by ta...@apache.org on 2018/03/20 20:44:12 UTC
[14/21] impala git commit: IMPALA-6683: Fix infinite loop after
restarting the catalog
IMPALA-6683: Fix infinite loop after restarting the catalog
Currently the catalog service ID topic item includes the ID string.
It causes the coexistence of multiple catalog service ID topic items
after the catalogd restarts. Impalad therefore keeps detecting the
change of catalog service ID and requests a full catalog update. This
patch uses "CATALOG_SERVICE_ID" as the topic item name instead.
With the patch impalad prints only one line of catalog change log after
the catalog restarts.
Change-Id: I1ee6c6477458e0f4dd31b12daa9ed5f146d84e7b
Reviewed-on: http://gerrit.cloudera.org:8080/9684
Reviewed-by: Alex Behm <al...@cloudera.com>
Reviewed-by: Dimitris Tsirogiannis <dt...@cloudera.com>
Tested-by: Impala Public Jenkins
Project: http://git-wip-us.apache.org/repos/asf/impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/impala/commit/9810ec6c
Tree: http://git-wip-us.apache.org/repos/asf/impala/tree/9810ec6c
Diff: http://git-wip-us.apache.org/repos/asf/impala/diff/9810ec6c
Branch: refs/heads/2.x
Commit: 9810ec6cdfcd4e4532e75cad5d1b8fca9e23cf61
Parents: 31d075f
Author: Tianyi Wang <tw...@cloudera.com>
Authored: Thu Mar 15 18:25:54 2018 -0700
Committer: Impala Public Jenkins <im...@gerrit.cloudera.org>
Committed: Sun Mar 18 21:03:22 2018 +0000
----------------------------------------------------------------------
fe/src/main/java/org/apache/impala/catalog/Catalog.java | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/impala/blob/9810ec6c/fe/src/main/java/org/apache/impala/catalog/Catalog.java
----------------------------------------------------------------------
diff --git a/fe/src/main/java/org/apache/impala/catalog/Catalog.java b/fe/src/main/java/org/apache/impala/catalog/Catalog.java
index bee5be5..6f9cdb5 100644
--- a/fe/src/main/java/org/apache/impala/catalog/Catalog.java
+++ b/fe/src/main/java/org/apache/impala/catalog/Catalog.java
@@ -575,8 +575,7 @@ public abstract class Catalog {
case DATA_SOURCE:
return "DATA_SOURCE:" + catalogObject.getData_source().getName().toLowerCase();
case CATALOG:
- return "CATALOG:" +
- TUniqueIdUtil.PrintId(catalogObject.getCatalog().catalog_service_id);
+ return "CATALOG_SERVICE_ID";
default:
throw new IllegalStateException(
"Unsupported catalog object type: " + catalogObject.getType());