You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/03/13 01:13:04 UTC
[GitHub] [incubator-apisix-dashboard] juzhiyuan opened a new issue #155:
Docker support & pass env when building
juzhiyuan opened a new issue #155: Docker support & pass env when building
URL: https://github.com/apache/incubator-apisix-dashboard/issues/155
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on issue #155:
Docker support & pass env when building
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #155: Docker support & pass env when building
URL: https://github.com/apache/incubator-apisix-dashboard/issues/155#issuecomment-613457731
Ok, I will assign it to you :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix-dashboard] bzp2010 commented on issue #155:
Docker support & pass env when building
Posted by GitBox <gi...@apache.org>.
bzp2010 commented on issue #155: Docker support & pass env when building
URL: https://github.com/apache/incubator-apisix-dashboard/issues/155#issuecomment-613197970
Does this mean we will write a `Dockerfile`, to build and run project in docker?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on issue #155:
Docker support & pass env when building
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #155: Docker support & pass env when building
URL: https://github.com/apache/incubator-apisix-dashboard/issues/155#issuecomment-613318177
Yep!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on issue #155:
Docker support & pass env when building
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #155: Docker support & pass env when building
URL: https://github.com/apache/incubator-apisix-dashboard/issues/155#issuecomment-614474127
Just write a bash script to only keep files under dist folder?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on issue #155:
Docker support & pass env when building
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #155: Docker support & pass env when building
URL: https://github.com/apache/incubator-apisix-dashboard/issues/155#issuecomment-614994817
ok, @bzp2010 Please go ahead for next branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix-dashboard] juzhiyuan edited a comment on issue
#155: Docker support & pass env when building
Posted by GitBox <gi...@apache.org>.
juzhiyuan edited a comment on issue #155: Docker support & pass env when building
URL: https://github.com/apache/incubator-apisix-dashboard/issues/155#issuecomment-614477092
1. Install `apisix`;
2. Git clone `apisix-dashboard` repo;
3. Build docker image, dashboard files will be bundled in this step;
4. Clean unused files and move bundled files under `apisix/dashboard` folder;
5. Remove the docker image in the end;
Please note, we use docker just to reduce the compiling error under our Docker env.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix-dashboard] moonming commented on issue #155:
Docker support & pass env when building
Posted by GitBox <gi...@apache.org>.
moonming commented on issue #155: Docker support & pass env when building
URL: https://github.com/apache/incubator-apisix-dashboard/issues/155#issuecomment-614631656
sure, we can add dashboard in docker image after 1.2 released.
bzp2010 <no...@github.com> 于 2020年4月16日周四 下午7:46写道：
> Yes.
> First, compile the dashboard during image construction, generate dist
> files, and then put these files into nginx image to expose the port.
>
> This may take advantage of CI facilities to build and upload images to the
> docker hub after each commit merge.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/incubator-apisix-dashboard/issues/155#issuecomment-614602646>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AGJZBK3SWAZJGIY6GTMO32LRM3V2ZANCNFSM4LGYRZWA>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on issue #155:
Docker support & pass env when building
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #155: Docker support & pass env when building
URL: https://github.com/apache/incubator-apisix-dashboard/issues/155#issuecomment-613318618
Because of different os environments, some users cannot build successfully.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on issue #155:
Docker support & pass env when building
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #155: Docker support & pass env when building
URL: https://github.com/apache/incubator-apisix-dashboard/issues/155#issuecomment-614472926
@bzp2010 Wow, good job! We could only contain those bundled files under dist folder in the image :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix-dashboard] juzhiyuan edited a comment on issue
#155: Docker support & pass env when building
Posted by GitBox <gi...@apache.org>.
juzhiyuan edited a comment on issue #155: Docker support & pass env when building
URL: https://github.com/apache/incubator-apisix-dashboard/issues/155#issuecomment-614472926
@bzp2010 oh yes, we should not contain node_modules in docker image.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix-dashboard] bzp2010 commented on issue #155:
Docker support & pass env when building
Posted by GitBox <gi...@apache.org>.
bzp2010 commented on issue #155: Docker support & pass env when building
URL: https://github.com/apache/incubator-apisix-dashboard/issues/155#issuecomment-614522950
Is this just to compile the program using a unified environment?
I think it is more suitable for docker to deploy dashboard through docker image to provide access.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix-dashboard] bzp2010 commented on issue #155:
Docker support & pass env when building
Posted by GitBox <gi...@apache.org>.
bzp2010 commented on issue #155: Docker support & pass env when building
URL: https://github.com/apache/incubator-apisix-dashboard/issues/155#issuecomment-614437952
I write a Dockerfile for test, I found that if the `node_modules` were packed into the image during the build process, the image file would be too large, about 1.3GB.
I think there are two ways to solve this problem
- Write a bash script to transfer the `npm install` process to the `docker run` process
- In the process of building the image, `npm install` is performed, and then the dashboard is compiled and packaged to generate the files for deployment, and the nginx driver is used to access them and delete the node_modules after packaging
I hope to get some suggestions. THX
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix-dashboard] bzp2010 commented on issue #155:
Docker support & pass env when building
Posted by GitBox <gi...@apache.org>.
bzp2010 commented on issue #155: Docker support & pass env when building
URL: https://github.com/apache/incubator-apisix-dashboard/issues/155#issuecomment-613444383
Since the dashboard will not have a lot of traffic, I think I can use nodejs as the underlying image for program building. Through it, we can realize the function of one key to run a dashboard.
At the same time, we should add the function of specifying API address of API gateway management through environment variable and dashboard settings.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on issue #155:
Docker support & pass env when building
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #155: Docker support & pass env when building
URL: https://github.com/apache/incubator-apisix-dashboard/issues/155#issuecomment-614569071
It's ok to deploy the dashboard inside the docker container, then we should add some configurations in `nginx.conf`, @membphis @moonming what's your opinion?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix-dashboard] bzp2010 edited a comment on issue
#155: Docker support & pass env when building
Posted by GitBox <gi...@apache.org>.
bzp2010 edited a comment on issue #155: Docker support & pass env when building
URL: https://github.com/apache/incubator-apisix-dashboard/issues/155#issuecomment-613444383
Since the dashboard will not have a lot of traffic, I think I can use nodejs as the underlying image for program building. Through it, we can realize the function of one key to run a dashboard.
At the same time, we should add the function of specifying API address of API gateway management through environment variable and dashboard settings.
I will try to finish it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix-dashboard] bzp2010 commented on issue #155:
Docker support & pass env when building
Posted by GitBox <gi...@apache.org>.
bzp2010 commented on issue #155: Docker support & pass env when building
URL: https://github.com/apache/incubator-apisix-dashboard/issues/155#issuecomment-614602646
Yes.
First, compile the dashboard during image construction, generate dist files, and then put these files into nginx image to expose the port.
> This may take advantage of CI facilities to build and upload images to the docker hub after each commit merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on issue #155:
Docker support & pass env when building
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #155: Docker support & pass env when building
URL: https://github.com/apache/incubator-apisix-dashboard/issues/155#issuecomment-614477092
1. Install `apisix`;
2. Git clone `apisix-dashboard` repo;
3. Build docker image, dashboard files will be bundled in this step;
4. Clean unused files and move bundled files under `apisix/dashboard` folder;
Please note, we use docker just to reduce the compiling error under our Docker env.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services