You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@creadur.apache.org by GitBox <gi...@apache.org> on 2020/12/15 14:54:14 UTC
[GitHub] [creadur-tentacles] ottlinger opened a new pull request #1: WIP: TENTACLES-12: Update to latest log4j2 and update dependencies and plugins
ottlinger opened a new pull request #1:
URL: https://github.com/apache/creadur-tentacles/pull/1
As log4j2 2.14.0 is built with JDK9 minimum some more updates are needed apart from build configuration and compilation changes in order to use log2j2 instead of v1.x with security problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [creadur-tentacles] ottlinger commented on pull request #1: TENTACLES-12: Update to latest log4j2 and update dependencies and plugins
Posted by GitBox <gi...@apache.org>.
ottlinger commented on pull request #1:
URL: https://github.com/apache/creadur-tentacles/pull/1#issuecomment-745395678
@jvz I tried to get this animal-sniffer-stuff up and running with jdk9 but it complained that log4j is JDK9.
As sniffer only supports JDK8 I had to remove it.
Any improvents are welcome if you have a running animal-sniffer-verification setup.
Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [creadur-tentacles] jvz commented on pull request #1: TENTACLES-12: Update to latest log4j2 and update dependencies and plugins
Posted by GitBox <gi...@apache.org>.
jvz commented on pull request #1:
URL: https://github.com/apache/creadur-tentacles/pull/1#issuecomment-745397153
https://github.com/mojohaus/animal-sniffer/pull/32
Seems like it was fixed a while ago (and by coworkers of mine, too, amusingly enough).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [creadur-tentacles] ottlinger commented on pull request #1: TENTACLES-12: Update to latest log4j2 and update dependencies and plugins
Posted by GitBox <gi...@apache.org>.
ottlinger commented on pull request #1:
URL: https://github.com/apache/creadur-tentacles/pull/1#issuecomment-745577532
@rmannibucau the Travis build is buggy as you get a different JDK than the one you selected as build JDK. This yielded various build failures in the past and is a known-issue at Travis.
The failed builds ran with JDK11 although 9 was requested ..... this makes builds fail that use animal-sniffer stuff, the build is/should be green on ASF infra.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [creadur-tentacles] ottlinger merged pull request #1: TENTACLES-12: Update to latest log4j2 and update dependencies and plugins
Posted by GitBox <gi...@apache.org>.
ottlinger merged pull request #1:
URL: https://github.com/apache/creadur-tentacles/pull/1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@creadur.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [creadur-tentacles] rmannibucau commented on a change in pull request #1: TENTACLES-12: Update to latest log4j2 and update dependencies and plugins
Posted by GitBox <gi...@apache.org>.
rmannibucau commented on a change in pull request #1:
URL: https://github.com/apache/creadur-tentacles/pull/1#discussion_r543695605
##########
File path: .travis.yml
##########
@@ -1,6 +1,6 @@
language: java
jdk:
- - openjdk8
+ - openjdk9
Review comment:
Guess we must keep java 8 there.
Between that and disabling a buggy plugin (animal sniffer) guess last one is saner.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [creadur-tentacles] jvz commented on pull request #1: TENTACLES-12: Update to latest log4j2 and update dependencies and plugins
Posted by GitBox <gi...@apache.org>.
jvz commented on pull request #1:
URL: https://github.com/apache/creadur-tentacles/pull/1#issuecomment-745393895
Log4j is built with Java 8 along with some version-specific code support for Java 9 and Java 11. You should be able to use it in Java 8. If you get errors from a tool about invalid bytecode, the tool isn't scanning jars correctly and has likely since been fixed as this was a common problem during the 8->9 transition.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [creadur-tentacles] ottlinger commented on pull request #1: TENTACLES-12: Update to latest log4j2 and update dependencies and plugins
Posted by GitBox <gi...@apache.org>.
ottlinger commented on pull request #1:
URL: https://github.com/apache/creadur-tentacles/pull/1#issuecomment-745409573
@jvz we ran with v1.16 - the problem is that there is no
```
<groupId>org.codehaus.mojo.signature</groupId>
<artifactId>java19</artifactId>
```
in order to scan for at least JDK9.
Runnig with java18 yielded the problem with log4j.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [creadur-tentacles] jvz commented on pull request #1: TENTACLES-12: Update to latest log4j2 and update dependencies and plugins
Posted by GitBox <gi...@apache.org>.
jvz commented on pull request #1:
URL: https://github.com/apache/creadur-tentacles/pull/1#issuecomment-745427677
Here's a more thorough example of what we've done in Jenkins to work around that: https://github.com/jenkinsci/plugin-pom/blob/3101645162a2c0a210fbd470140b7013fcd9799f/pom.xml#L464-L549
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [creadur-tentacles] rmannibucau commented on pull request #1: TENTACLES-12: Update to latest log4j2 and update dependencies and plugins
Posted by GitBox <gi...@apache.org>.
rmannibucau commented on pull request #1:
URL: https://github.com/apache/creadur-tentacles/pull/1#issuecomment-745431905
Guess we can also simply move creadur to JUL, there is no real reason to use log4j (in particular until it gets v3 cause it is way too fat and slow to start these days :().
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [creadur-tentacles] ottlinger commented on pull request #1: TENTACLES-12: Update to latest log4j2 and update dependencies and plugins
Posted by GitBox <gi...@apache.org>.
ottlinger commented on pull request #1:
URL: https://github.com/apache/creadur-tentacles/pull/1#issuecomment-1000357468
After some changes in the enforcer-plugin configuration the build runs successfully with JDK8 - thanks for all your input.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@creadur.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org