You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2019/03/12 12:20:10 UTC

[GitHub] [cloudstack] GabrielBrascher edited a comment on issue #3210: systemd: Fix -Dpid arg passing to systemd usage service

GabrielBrascher edited a comment on issue #3210: systemd: Fix -Dpid arg passing to systemd usage service
URL: https://github.com/apache/cloudstack/pull/3210#issuecomment-471977036
 
 
   @rhtyd it looks good. Thanks!
   
   Can you please also remove the lines that are silencing the exception? I don't see any reason for print on the stack trace (console) the exceptions.
   https://github.com/apache/cloudstack/blob/1d05fead49f5c856257a741b07122f5633d2e359/usage/src/main/java/com/cloud/usage/UsageServer.java#L54
   
   ```
   } catch (Exception e) {
       e.printStackTrace();
   }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services