You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Aditya Kishore <ad...@gmail.com> on 2014/04/03 16:10:04 UTC
Re: Review Request 19723: DRILL-452: Conversion functions for external data
types
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19723/
-----------------------------------------------------------
(Updated April 3, 2014, 7:09 a.m.)
Review request for drill, Jacques Nadeau, Steven Phillips, and Venki Korukanti.
Changes
-------
Added remaining conversion function for the first phase. Now following conversion format are supported.
BOOLEAN_BYTE
TINYINT_BE
TINYINT
SMALLINT_BE
SMALLINT
INT_BE
INT
BIGINT_BE
BIGINT
FLOAT
DOUBLE
INT_HADOOPV
BIGINT_HADOOPV
DATE_EPOCH_BE
DATE_EPOCH
TIME_EPOCH_BE
TIME_EPOCH
UTF8
UTF16
UINT8
Note: This patch is based on the current head (db077622) of 'tpch_work' branch plus few other patches (DRILL-474, DRILL-475, DRILL-476, DRILL-477) which are not part of this diff.
Bugs: DRILL-452
https://issues.apache.org/jira/browse/DRILL-452
Repository: drill-git
Description
-------
This patch provides the foundation for drill convert_to() and convert_from() functions along with couple of implementations.
Diffs (updated)
-----
common/src/main/antlr3/org/apache/drill/common/expression/parser/ExprLexer.g be2a3f2
common/src/main/antlr3/org/apache/drill/common/expression/parser/ExprParser.g b60e2d6
common/src/main/java/org/apache/drill/common/expression/ConvertExpression.java PRE-CREATION
common/src/main/java/org/apache/drill/common/expression/ExpressionStringBuilder.java 80fd41b
common/src/main/java/org/apache/drill/common/expression/FunctionCallFactory.java c6c7074
common/src/main/java/org/apache/drill/common/expression/visitors/AbstractExprVisitor.java 727a3dc
common/src/main/java/org/apache/drill/common/expression/visitors/AggregateChecker.java 100bf94
common/src/main/java/org/apache/drill/common/expression/visitors/ConstantChecker.java 60e997f
common/src/main/java/org/apache/drill/common/expression/visitors/ExprVisitor.java e199f21
common/src/main/java/org/apache/drill/common/expression/visitors/ExpressionValidator.java cf110cd
common/src/main/java/org/apache/drill/common/types/Types.java fd8991d
exec/java-exec/src/main/java/org/apache/drill/exec/compile/sig/ConstantExpressionIdentifier.java e476897
exec/java-exec/src/main/java/org/apache/drill/exec/expr/EvaluationVisitor.java 8dfba76
exec/java-exec/src/main/java/org/apache/drill/exec/expr/ExpressionTreeMaterializer.java f764d32
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/BigIntBEConvertFrom.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/BigIntBEConvertTo.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/BigIntConvertFrom.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/BigIntConvertTo.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/BigIntVLongConvertFrom.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/BigIntVLongConvertTo.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/BooleanByteConvertFrom.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/BooleanByteConvertTo.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/DateEpochBEConvertFrom.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/DateEpochBEConvertTo.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/DateEpochConvertFrom.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/DateEpochConvertTo.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/DoubleConvertFrom.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/DoubleConvertTo.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/FloatConvertFrom.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/FloatConvertTo.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/IntBEConvertFrom.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/IntBEConvertTo.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/IntConvertFrom.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/IntConvertTo.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/IntVIntConvertFrom.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/IntVIntConvertTo.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/SmallIntBEConvertFrom.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/SmallIntBEConvertTo.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/SmallIntConvertFrom.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/SmallIntConvertTo.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/TimeEpochBEConvertFrom.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/TimeEpochBEConvertTo.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/TimeEpochConvertFrom.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/TimeEpochConvertTo.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/TinyIntConvertFrom.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/TinyIntConvertTo.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/UInt8ConvertFrom.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/UInt8ConvertTo.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/UTF16ConvertFrom.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/UTF16ConvertTo.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/UTF8ConvertFrom.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/UTF8ConvertTo.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/resolver/TypeCastRules.java 12ca75d
exec/java-exec/src/main/java/org/apache/drill/exec/store/hive/HiveRecordReader.java 5bd520d
exec/java-exec/src/main/java/org/apache/drill/exec/util/ConvertUtil.java PRE-CREATION
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestConvertFunctions.java PRE-CREATION
exec/java-exec/src/test/resources/functions/conv/conversionTestWithLogicalPlan.json PRE-CREATION
exec/java-exec/src/test/resources/functions/conv/conversionTestWithPhysicalPlan.json PRE-CREATION
Diff: https://reviews.apache.org/r/19723/diff/
Testing
-------
* Existing Drill unit test suit.
* New test case TestConvertFunctions.
Thanks,
Aditya Kishore
Re: Review Request 19723: DRILL-452: Conversion functions for external data
types
Posted by Aditya Kishore <ad...@gmail.com>.
> On April 15, 2014, 5:27 p.m., Steven Phillips wrote:
> > exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/SmallIntConvertTo.java, line 34
> > <https://reviews.apache.org/r/19723/diff/5/?file=547766#file547766line34>
> >
> > Would it be very difficult to generate these functions instead of writing them by hand?
Unlike CAST expressions, these would result in same number of templates as the functions, hence I am not very much inclined.
- Aditya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19723/#review40483
-----------------------------------------------------------
On April 3, 2014, 7:09 a.m., Aditya Kishore wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19723/
> -----------------------------------------------------------
>
> (Updated April 3, 2014, 7:09 a.m.)
>
>
> Review request for drill, Jacques Nadeau, Steven Phillips, and Venki Korukanti.
>
>
> Bugs: DRILL-452
> https://issues.apache.org/jira/browse/DRILL-452
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> This patch provides the foundation for drill convert_to() and convert_from() functions along with couple of implementations.
>
>
> Diffs
> -----
>
> common/src/main/antlr3/org/apache/drill/common/expression/parser/ExprLexer.g be2a3f2
> common/src/main/antlr3/org/apache/drill/common/expression/parser/ExprParser.g b60e2d6
> common/src/main/java/org/apache/drill/common/expression/ConvertExpression.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/expression/ExpressionStringBuilder.java 80fd41b
> common/src/main/java/org/apache/drill/common/expression/FunctionCallFactory.java c6c7074
> common/src/main/java/org/apache/drill/common/expression/visitors/AbstractExprVisitor.java 727a3dc
> common/src/main/java/org/apache/drill/common/expression/visitors/AggregateChecker.java 100bf94
> common/src/main/java/org/apache/drill/common/expression/visitors/ConstantChecker.java 60e997f
> common/src/main/java/org/apache/drill/common/expression/visitors/ExprVisitor.java e199f21
> common/src/main/java/org/apache/drill/common/expression/visitors/ExpressionValidator.java cf110cd
> common/src/main/java/org/apache/drill/common/types/Types.java fd8991d
> exec/java-exec/src/main/java/org/apache/drill/exec/compile/sig/ConstantExpressionIdentifier.java e476897
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/EvaluationVisitor.java 8dfba76
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/ExpressionTreeMaterializer.java f764d32
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/BigIntBEConvertFrom.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/BigIntBEConvertTo.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/BigIntConvertFrom.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/BigIntConvertTo.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/BigIntVLongConvertFrom.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/BigIntVLongConvertTo.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/BooleanByteConvertFrom.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/BooleanByteConvertTo.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/DateEpochBEConvertFrom.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/DateEpochBEConvertTo.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/DateEpochConvertFrom.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/DateEpochConvertTo.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/DoubleConvertFrom.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/DoubleConvertTo.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/FloatConvertFrom.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/FloatConvertTo.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/IntBEConvertFrom.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/IntBEConvertTo.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/IntConvertFrom.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/IntConvertTo.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/IntVIntConvertFrom.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/IntVIntConvertTo.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/SmallIntBEConvertFrom.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/SmallIntBEConvertTo.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/SmallIntConvertFrom.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/SmallIntConvertTo.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/TimeEpochBEConvertFrom.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/TimeEpochBEConvertTo.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/TimeEpochConvertFrom.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/TimeEpochConvertTo.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/TinyIntConvertFrom.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/TinyIntConvertTo.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/UInt8ConvertFrom.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/UInt8ConvertTo.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/UTF16ConvertFrom.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/UTF16ConvertTo.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/UTF8ConvertFrom.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/UTF8ConvertTo.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/resolver/TypeCastRules.java 12ca75d
> exec/java-exec/src/main/java/org/apache/drill/exec/store/hive/HiveRecordReader.java 5bd520d
> exec/java-exec/src/main/java/org/apache/drill/exec/util/ConvertUtil.java PRE-CREATION
> exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestConvertFunctions.java PRE-CREATION
> exec/java-exec/src/test/resources/functions/conv/conversionTestWithLogicalPlan.json PRE-CREATION
> exec/java-exec/src/test/resources/functions/conv/conversionTestWithPhysicalPlan.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/19723/diff/
>
>
> Testing
> -------
>
> * Existing Drill unit test suit.
> * New test case TestConvertFunctions.
>
>
> Thanks,
>
> Aditya Kishore
>
>
Re: Review Request 19723: DRILL-452: Conversion functions for external data
types
Posted by Steven Phillips <sp...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19723/#review40483
-----------------------------------------------------------
common/src/main/java/org/apache/drill/common/types/Types.java
<https://reviews.apache.org/r/19723/#comment73512>
I think it would be better to return a MinorType, and then let the caller choose the DataMode, rather than returning a REQUIRED type here.
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/SmallIntConvertTo.java
<https://reviews.apache.org/r/19723/#comment73508>
Would it be very difficult to generate these functions instead of writing them by hand?
- Steven Phillips
On April 3, 2014, 2:09 p.m., Aditya Kishore wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19723/
> -----------------------------------------------------------
>
> (Updated April 3, 2014, 2:09 p.m.)
>
>
> Review request for drill, Jacques Nadeau, Steven Phillips, and Venki Korukanti.
>
>
> Bugs: DRILL-452
> https://issues.apache.org/jira/browse/DRILL-452
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> This patch provides the foundation for drill convert_to() and convert_from() functions along with couple of implementations.
>
>
> Diffs
> -----
>
> common/src/main/antlr3/org/apache/drill/common/expression/parser/ExprLexer.g be2a3f2
> common/src/main/antlr3/org/apache/drill/common/expression/parser/ExprParser.g b60e2d6
> common/src/main/java/org/apache/drill/common/expression/ConvertExpression.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/expression/ExpressionStringBuilder.java 80fd41b
> common/src/main/java/org/apache/drill/common/expression/FunctionCallFactory.java c6c7074
> common/src/main/java/org/apache/drill/common/expression/visitors/AbstractExprVisitor.java 727a3dc
> common/src/main/java/org/apache/drill/common/expression/visitors/AggregateChecker.java 100bf94
> common/src/main/java/org/apache/drill/common/expression/visitors/ConstantChecker.java 60e997f
> common/src/main/java/org/apache/drill/common/expression/visitors/ExprVisitor.java e199f21
> common/src/main/java/org/apache/drill/common/expression/visitors/ExpressionValidator.java cf110cd
> common/src/main/java/org/apache/drill/common/types/Types.java fd8991d
> exec/java-exec/src/main/java/org/apache/drill/exec/compile/sig/ConstantExpressionIdentifier.java e476897
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/EvaluationVisitor.java 8dfba76
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/ExpressionTreeMaterializer.java f764d32
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/BigIntBEConvertFrom.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/BigIntBEConvertTo.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/BigIntConvertFrom.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/BigIntConvertTo.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/BigIntVLongConvertFrom.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/BigIntVLongConvertTo.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/BooleanByteConvertFrom.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/BooleanByteConvertTo.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/DateEpochBEConvertFrom.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/DateEpochBEConvertTo.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/DateEpochConvertFrom.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/DateEpochConvertTo.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/DoubleConvertFrom.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/DoubleConvertTo.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/FloatConvertFrom.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/FloatConvertTo.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/IntBEConvertFrom.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/IntBEConvertTo.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/IntConvertFrom.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/IntConvertTo.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/IntVIntConvertFrom.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/IntVIntConvertTo.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/SmallIntBEConvertFrom.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/SmallIntBEConvertTo.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/SmallIntConvertFrom.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/SmallIntConvertTo.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/TimeEpochBEConvertFrom.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/TimeEpochBEConvertTo.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/TimeEpochConvertFrom.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/TimeEpochConvertTo.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/TinyIntConvertFrom.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/TinyIntConvertTo.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/UInt8ConvertFrom.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/UInt8ConvertTo.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/UTF16ConvertFrom.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/UTF16ConvertTo.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/UTF8ConvertFrom.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/UTF8ConvertTo.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/resolver/TypeCastRules.java 12ca75d
> exec/java-exec/src/main/java/org/apache/drill/exec/store/hive/HiveRecordReader.java 5bd520d
> exec/java-exec/src/main/java/org/apache/drill/exec/util/ConvertUtil.java PRE-CREATION
> exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestConvertFunctions.java PRE-CREATION
> exec/java-exec/src/test/resources/functions/conv/conversionTestWithLogicalPlan.json PRE-CREATION
> exec/java-exec/src/test/resources/functions/conv/conversionTestWithPhysicalPlan.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/19723/diff/
>
>
> Testing
> -------
>
> * Existing Drill unit test suit.
> * New test case TestConvertFunctions.
>
>
> Thanks,
>
> Aditya Kishore
>
>
Re: Review Request 19723: DRILL-452: Conversion functions for external data
types
Posted by Aditya Kishore <ad...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19723/#review41072
-----------------------------------------------------------
common/src/main/java/org/apache/drill/common/types/Types.java
<https://reviews.apache.org/r/19723/#comment74455>
Resolved in the updated patch.
- Aditya Kishore
On April 3, 2014, 7:09 a.m., Aditya Kishore wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19723/
> -----------------------------------------------------------
>
> (Updated April 3, 2014, 7:09 a.m.)
>
>
> Review request for drill, Jacques Nadeau, Steven Phillips, and Venki Korukanti.
>
>
> Bugs: DRILL-452
> https://issues.apache.org/jira/browse/DRILL-452
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> This patch provides the foundation for drill convert_to() and convert_from() functions along with couple of implementations.
>
>
> Diffs
> -----
>
> common/src/main/antlr3/org/apache/drill/common/expression/parser/ExprLexer.g be2a3f2
> common/src/main/antlr3/org/apache/drill/common/expression/parser/ExprParser.g b60e2d6
> common/src/main/java/org/apache/drill/common/expression/ConvertExpression.java PRE-CREATION
> common/src/main/java/org/apache/drill/common/expression/ExpressionStringBuilder.java 80fd41b
> common/src/main/java/org/apache/drill/common/expression/FunctionCallFactory.java c6c7074
> common/src/main/java/org/apache/drill/common/expression/visitors/AbstractExprVisitor.java 727a3dc
> common/src/main/java/org/apache/drill/common/expression/visitors/AggregateChecker.java 100bf94
> common/src/main/java/org/apache/drill/common/expression/visitors/ConstantChecker.java 60e997f
> common/src/main/java/org/apache/drill/common/expression/visitors/ExprVisitor.java e199f21
> common/src/main/java/org/apache/drill/common/expression/visitors/ExpressionValidator.java cf110cd
> common/src/main/java/org/apache/drill/common/types/Types.java fd8991d
> exec/java-exec/src/main/java/org/apache/drill/exec/compile/sig/ConstantExpressionIdentifier.java e476897
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/EvaluationVisitor.java 8dfba76
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/ExpressionTreeMaterializer.java f764d32
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/BigIntBEConvertFrom.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/BigIntBEConvertTo.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/BigIntConvertFrom.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/BigIntConvertTo.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/BigIntVLongConvertFrom.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/BigIntVLongConvertTo.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/BooleanByteConvertFrom.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/BooleanByteConvertTo.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/DateEpochBEConvertFrom.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/DateEpochBEConvertTo.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/DateEpochConvertFrom.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/DateEpochConvertTo.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/DoubleConvertFrom.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/DoubleConvertTo.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/FloatConvertFrom.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/FloatConvertTo.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/IntBEConvertFrom.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/IntBEConvertTo.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/IntConvertFrom.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/IntConvertTo.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/IntVIntConvertFrom.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/IntVIntConvertTo.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/SmallIntBEConvertFrom.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/SmallIntBEConvertTo.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/SmallIntConvertFrom.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/SmallIntConvertTo.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/TimeEpochBEConvertFrom.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/TimeEpochBEConvertTo.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/TimeEpochConvertFrom.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/TimeEpochConvertTo.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/TinyIntConvertFrom.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/TinyIntConvertTo.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/UInt8ConvertFrom.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/UInt8ConvertTo.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/UTF16ConvertFrom.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/UTF16ConvertTo.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/UTF8ConvertFrom.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/UTF8ConvertTo.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/resolver/TypeCastRules.java 12ca75d
> exec/java-exec/src/main/java/org/apache/drill/exec/store/hive/HiveRecordReader.java 5bd520d
> exec/java-exec/src/main/java/org/apache/drill/exec/util/ConvertUtil.java PRE-CREATION
> exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestConvertFunctions.java PRE-CREATION
> exec/java-exec/src/test/resources/functions/conv/conversionTestWithLogicalPlan.json PRE-CREATION
> exec/java-exec/src/test/resources/functions/conv/conversionTestWithPhysicalPlan.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/19723/diff/
>
>
> Testing
> -------
>
> * Existing Drill unit test suit.
> * New test case TestConvertFunctions.
>
>
> Thanks,
>
> Aditya Kishore
>
>