You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/07/12 02:49:38 UTC

[GitHub] [superset] stephenLYZ commented on a diff in pull request #20627: fix(chart): Time Series set showMaxLabel as null for time xAxis

stephenLYZ commented on code in PR #20627:
URL: https://github.com/apache/superset/pull/20627#discussion_r918500308


##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts:
##########
@@ -326,13 +327,23 @@ export default function transformProps(
       rotate: xAxisLabelRotation,

Review Comment:
   ```suggestion
         rotate: xAxisLabelRotation,
   ```
   ```suggestion
         rotate: xAxisLabelRotation,
         showLabel: xAxisType === AxisType.time ? null : false,
   ```
   
   looks like we can use one line to meet the requirement 🤔



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org