You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by zbdzzg <gi...@git.apache.org> on 2016/11/21 12:31:55 UTC
[GitHub] drill pull request #662: DRILL-5051: Fix incorrect result returned in nest q...
GitHub user zbdzzg opened a pull request:
https://github.com/apache/drill/pull/662
DRILL-5051: Fix incorrect result returned in nest query with offset s\u2026
\u2026pecified
1. Fix this problem.
2. Merge two limit methods, most of code is the same.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zbdzzg/drill 5051
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/662.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #662
----
commit 102ad402250c0d74c9ab7a724aef3262b92069d8
Author: hongze.zhz <ho...@alibaba-inc.com>
Date: 2016-11-18T12:11:38Z
DRILL-5051: Fix incorrect result returned in nest query with offset specified
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request #662: DRILL-5051: Fix incorrect result returned in nest q...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/662
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill issue #662: DRILL-5051: Fix incorrect result returned in nest query wi...
Posted by zbdzzg <gi...@git.apache.org>.
Github user zbdzzg commented on the issue:
https://github.com/apache/drill/pull/662
@sudheeshkatkam Could you please review this? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request #662: DRILL-5051: Fix incorrect result returned in nest q...
Posted by jinfengni <gi...@git.apache.org>.
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/662#discussion_r93146424
--- Diff: exec/java-exec/src/test/java/org/apache/drill/TestBugFixes.java ---
@@ -221,4 +221,14 @@ public void testDRILL4884() throws Exception {
.baselineRecords(baseline)
.go();
}
+
+ @Test
+ public void testDRILL5051() throws Exception {
+ testBuilder()
+ .sqlQuery("select count(1) as cnt from (select l_orderkey from (select id from cp.`tpch/lineitem.parquet` limit 2) limit 1 offset 1)")
--- End diff --
This query seems to hit SQL validation error " Column 'l_orderkey' not found in any table".
I'm going to change column "id" to "l_orderkey" in the inner subquery, in order to skip this validation error.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill issue #662: DRILL-5051: Fix incorrect result returned in nest query wi...
Posted by zbdzzg <gi...@git.apache.org>.
Github user zbdzzg commented on the issue:
https://github.com/apache/drill/pull/662
@sudheeshkatkam Thanks for your review, commit message has been changed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill issue #662: DRILL-5051: Fix incorrect result returned in nest query wi...
Posted by sudheeshkatkam <gi...@git.apache.org>.
Github user sudheeshkatkam commented on the issue:
https://github.com/apache/drill/pull/662
@zbdzzg Thank you for the patch!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request #662: DRILL-5051: Fix incorrect result returned in nest q...
Posted by zbdzzg <gi...@git.apache.org>.
Github user zbdzzg commented on a diff in the pull request:
https://github.com/apache/drill/pull/662#discussion_r93163164
--- Diff: exec/java-exec/src/test/java/org/apache/drill/TestBugFixes.java ---
@@ -221,4 +221,14 @@ public void testDRILL4884() throws Exception {
.baselineRecords(baseline)
.go();
}
+
+ @Test
+ public void testDRILL5051() throws Exception {
+ testBuilder()
+ .sqlQuery("select count(1) as cnt from (select l_orderkey from (select id from cp.`tpch/lineitem.parquet` limit 2) limit 1 offset 1)")
--- End diff --
Thank you for the catch!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill issue #662: DRILL-5051: Fix incorrect result returned in nest query wi...
Posted by sudheeshkatkam <gi...@git.apache.org>.
Github user sudheeshkatkam commented on the issue:
https://github.com/apache/drill/pull/662
+1
Can you please change the commit message to "DRILL-5051: Fix incorrect computation of 'fetch' in LimitRecordBatch when 'offset' is specified"? The JIRA/PR title is fine as is.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---