You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by agresch <gi...@git.apache.org> on 2018/10/03 20:26:27 UTC
[GitHub] storm pull request #2861: STORM-3244 allow logviewer to use independent filt...
GitHub user agresch opened a pull request:
https://github.com/apache/storm/pull/2861
STORM-3244 allow logviewer to use independent filter settings from ui
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/agresch/storm agresch_logviewer_filter
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2861.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2861
----
commit 9cad3415e597bd25534d64271109653676d9be46
Author: Aaron Gresch <ag...@...>
Date: 2018-10-03T20:25:02Z
STORM-3244 allow logviewer to use independent filter settings from ui
----
---
[GitHub] storm issue #2861: STORM-3244 allow logviewer to use independent filter sett...
Posted by agresch <gi...@git.apache.org>.
Github user agresch commented on the issue:
https://github.com/apache/storm/pull/2861
@revans2 - added fallback to ui filter.
---
[GitHub] storm pull request #2861: STORM-3244 allow logviewer to use independent filt...
Posted by agresch <gi...@git.apache.org>.
Github user agresch commented on a diff in the pull request:
https://github.com/apache/storm/pull/2861#discussion_r223054311
--- Diff: storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/LogviewerServer.java ---
@@ -66,10 +64,9 @@ private static Server mkHttpServer(StormMetricsRegistry metricsRegistry, Map<Str
Server ret = null;
if (logviewerHttpPort != null && logviewerHttpPort >= 0) {
LOG.info("Starting Logviewer HTTP servers...");
- Integer headerBufferSize = ObjectReader.getInt(conf.get(UI_HEADER_BUFFER_BYTES));
- String filterClass = (String) (conf.get(DaemonConfig.UI_FILTER));
+ String filterClass = (String) (conf.get(DaemonConfig.LOGVIEWER_FILTER));
@SuppressWarnings("unchecked")
- Map<String, String> filterParams = (Map<String, String>) (conf.get(DaemonConfig.UI_FILTER_PARAMS));
+ Map<String, String> filterParams = (Map<String, String>) (conf.get(DaemonConfig.LOGVIEWER_FILTER_PARAMS));
--- End diff --
sure.
---
[GitHub] storm pull request #2861: STORM-3244 allow logviewer to use independent filt...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2861
---
[GitHub] storm pull request #2861: STORM-3244 allow logviewer to use independent filt...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2861#discussion_r223047510
--- Diff: storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/LogviewerServer.java ---
@@ -66,10 +64,9 @@ private static Server mkHttpServer(StormMetricsRegistry metricsRegistry, Map<Str
Server ret = null;
if (logviewerHttpPort != null && logviewerHttpPort >= 0) {
LOG.info("Starting Logviewer HTTP servers...");
- Integer headerBufferSize = ObjectReader.getInt(conf.get(UI_HEADER_BUFFER_BYTES));
- String filterClass = (String) (conf.get(DaemonConfig.UI_FILTER));
+ String filterClass = (String) (conf.get(DaemonConfig.LOGVIEWER_FILTER));
@SuppressWarnings("unchecked")
- Map<String, String> filterParams = (Map<String, String>) (conf.get(DaemonConfig.UI_FILTER_PARAMS));
+ Map<String, String> filterParams = (Map<String, String>) (conf.get(DaemonConfig.LOGVIEWER_FILTER_PARAMS));
--- End diff --
Can we do something where this falls back to the UI_FILTER/UI_FILTER_PARAMS if the LOGVIEWER ones are not set? That way we can maintain backwards compatibility and still offer the option to separate the two?
---