You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "arjun4084346 (via GitHub)" <gi...@apache.org> on 2023/04/13 00:46:09 UTC

[GitHub] [gobblin] arjun4084346 commented on a diff in pull request #3678: [GOBBLIN-1817] change some deprecated code and fix minor codestyle

arjun4084346 commented on code in PR #3678:
URL: https://github.com/apache/gobblin/pull/3678#discussion_r1164809338


##########
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/YarnService.java:
##########
@@ -453,7 +453,7 @@ private EventSubmitter buildEventSubmitter() {
   /**
    * Request an allocation of containers. If numTargetContainers is larger than the max of current and expected number
    * of containers then additional containers are requested.
-   *
+   * <p>

Review Comment:
   As per https://www.oracle.com/technical-resources/articles/java/javadoc-tool.html , it does not need a closing tag. It's more like a paragraph separator than a paragraph limits definer. I just followed what IntelliJ suggested.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org