You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by sl...@apache.org on 2026/08/08 08:50:13 UTC

(maven-gpg-plugin) branch master updated: Let the excludes IT see the POM pair Maven 4 installs

This is an automated email from the ASF dual-hosted git repository.

slachiewicz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-gpg-plugin.git


The following commit(s) were added to refs/heads/master by this push:
     new 17f4de8  Let the excludes IT see the POM pair Maven 4 installs
17f4de8 is described below

commit 17f4de8f2ae7a7f5e2599385841196804df53624
Author: Sylwester Lachiewicz <sl...@apache.org>
AuthorDate: Sat Aug 8 10:30:56 2026 +0200

    Let the excludes IT see the POM pair Maven 4 installs
    
    Maven 4 installs a build POM next to the consumer POM, and gpg signs
    both, so four POM files land in the local repository instead of two.
    sign-release-with-excludes is the only IT that walks the installed
    directory and rejects anything not on its list -- it has to, because it
    signs twice and its job is to prove the second run creates no .asc.asc
    -- so the two extra names made it fail under Maven 4.
    
    Add them to the list rather than skipping them, to keep the check
    exhaustive. The names are inert on Maven 3, which installs neither.
    
    The clause that skipped *consumer.pom had stopped matching anything:
    Maven 4 installs the consumer POM under the plain artifact name these
    days, and it is the build POM that carries the suffix.
---
 src/it/sign-release-with-excludes/verify.groovy | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/src/it/sign-release-with-excludes/verify.groovy b/src/it/sign-release-with-excludes/verify.groovy
index eeeed65..66d4bb2 100644
--- a/src/it/sign-release-with-excludes/verify.groovy
+++ b/src/it/sign-release-with-excludes/verify.groovy
@@ -22,6 +22,9 @@ var expectedFiles = [
     "_remote.repositories",
     "test-1.0.pom",
     "test-1.0.pom.asc",
+    // maven4 installs the build POM next to the consumer POM, and signs both
+    "test-1.0-build.pom",
+    "test-1.0-build.pom.asc",
     "test-1.0.jar",
     "test-1.0.jar.asc",
     "test-1.0-sources.jar",
@@ -31,11 +34,6 @@ var expectedFiles = [
 for (File file : artifactDir.listFiles()) {
     var fileName = file.getName()
 
-    //maven4: skip consumer POM
-    if (fileName.endsWith("consumer.pom") || fileName.endsWith("consumer.pom.asc")) {
-        continue
-    }
-
     println "Checking if file is expected: $file"
 
     var expected = false;