You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/10/29 11:10:19 UTC

[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #1548: fix error log when building route chain in the case we didn't configu…

AlexStocks commented on a change in pull request #1548:
URL: https://github.com/apache/dubbo-go/pull/1548#discussion_r739143367



##########
File path: cluster/router/v3router/router_chain.go
##########
@@ -48,10 +48,11 @@ func NewUniformRouterChain() (router.PriorityRouter, error) {
 	// 1. add mesh route listener
 	r := &RouterChain{}
 	rootConfig := config.GetRootConfig()
-	dynamicConfiguration, err := rootConfig.ConfigCenter.GetDynamicConfiguration()
-	if err != nil {
-		return nil, err
+	if rootConfig.ConfigCenter.DynamicConfiguration == nil {
+		logger.Infof("Config center does not start, please check if the configuration center has been properly configured in dubbogo.yml")

Review comment:
       the log level maybe should be warn?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org