You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "jackjlli (via GitHub)" <gi...@apache.org> on 2024/05/25 00:40:34 UTC
[PR] Mark resize as NumGroupsLimitReached in broker reduce phase [pinot]
jackjlli opened a new pull request, #13223:
URL: https://github.com/apache/pinot/pull/13223
Currently if the indexed table gets resized because the `trimSize` limit is reached, the accuracy of the results will be affected.
Thus, this PR marks resizing as one of the factors for NumGroupsLimitReached, so that user is able to be aware of the impact for the accuracy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Introduce brokerResized in broker reduce phase [pinot]
Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 closed pull request #13223: Introduce brokerResized in broker reduce phase
URL: https://github.com/apache/pinot/pull/13223
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Mark resize as NumGroupsLimitReached in broker reduce phase [pinot]
Posted by "jackjlli (via GitHub)" <gi...@apache.org>.
jackjlli commented on PR #13223:
URL: https://github.com/apache/pinot/pull/13223#issuecomment-2135860441
Thanks @Jackie-Jiang for sharing the insights! Yes, the intention here is to see how accurate the result would be. Most of the time we should be fine given that the trim size is set to at least 5x the limit size, while there are some scenarios where the number of responded servers is greater than 5 and it's still possible that resizing be triggered because of the reach of the 5x limit size. Let me introduce a new flag to cover the scenarios we discussed here. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Introduce brokerResized in broker reduce phase [pinot]
Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 commented on PR #13223:
URL: https://github.com/apache/pinot/pull/13223#issuecomment-4746473829
Closing this PR as stale because it has had no activity for more than one year (last updated before 2025-06-18). If this is still relevant, please reopen it or open a fresh PR against current master. Thanks for the contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org