You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jacob Janco <jj...@gmail.com> on 2019/07/17 20:38:33 UTC
Review Request 71106: Moved kernelVersion check to common code.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71106/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos
Description
-------
Moved kernelVersion check to common code.
Diffs
-----
src/common/kernel_version.hpp PRE-CREATION
src/linux/ns.cpp 2440bb2232dfd9cf57a6cc36aeff874c96297c4b
Diff: https://reviews.apache.org/r/71106/diff/1/
Testing
-------
Thanks,
Jacob Janco
Re: Review Request 71106: Moved kernelVersion check to common code.
Posted by Jacob Janco <jj...@gmail.com>.
> On July 18, 2019, 7:37 a.m., James Peach wrote:
> > src/common/kernel_version.hpp
> > Lines 17 (patched)
> > <https://reviews.apache.org/r/71106/diff/1/?file=2155817#file2155817line17>
> >
> > This should be `__KERNEL_VERSION_HPP__` to match the file name.
Ah missed that fixed.
> On July 18, 2019, 7:37 a.m., James Peach wrote:
> > src/common/kernel_version.hpp
> > Lines 24 (patched)
> > <https://reviews.apache.org/r/71106/diff/1/?file=2155817#file2155817line24>
> >
> > Once you move the function body, you can remove the `using` statements and the only remaingin includes should be `try.hpp` and `stout/version.hpp`.
Fixed.
> On July 18, 2019, 7:37 a.m., James Peach wrote:
> > src/common/kernel_version.hpp
> > Lines 31 (patched)
> > <https://reviews.apache.org/r/71106/diff/1/?file=2155817#file2155817line31>
> >
> > Can you please move this into `kernel_version.cpp`?
Sure
- Jacob
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71106/#review216712
-----------------------------------------------------------
On July 17, 2019, 8:38 p.m., Jacob Janco wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71106/
> -----------------------------------------------------------
>
> (Updated July 17, 2019, 8:38 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Moved kernelVersion check to common code.
>
>
> Diffs
> -----
>
> src/common/kernel_version.hpp PRE-CREATION
> src/linux/ns.cpp 2440bb2232dfd9cf57a6cc36aeff874c96297c4b
>
>
> Diff: https://reviews.apache.org/r/71106/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jacob Janco
>
>
Re: Review Request 71106: Moved kernelVersion check to common code.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71106/#review216712
-----------------------------------------------------------
Please add both `kernel_version.hpp` and `kernel_version.cpp` to `src/Makefile.am` (the headers are always needed for dist tarballs).
src/common/kernel_version.hpp
Lines 17 (patched)
<https://reviews.apache.org/r/71106/#comment303902>
This should be `__KERNEL_VERSION_HPP__` to match the file name.
src/common/kernel_version.hpp
Lines 24 (patched)
<https://reviews.apache.org/r/71106/#comment303904>
Once you move the function body, you can remove the `using` statements and the only remaingin includes should be `try.hpp` and `stout/version.hpp`.
src/common/kernel_version.hpp
Lines 31 (patched)
<https://reviews.apache.org/r/71106/#comment303903>
Can you please move this into `kernel_version.cpp`?
- James Peach
On July 17, 2019, 8:38 p.m., Jacob Janco wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71106/
> -----------------------------------------------------------
>
> (Updated July 17, 2019, 8:38 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Moved kernelVersion check to common code.
>
>
> Diffs
> -----
>
> src/common/kernel_version.hpp PRE-CREATION
> src/linux/ns.cpp 2440bb2232dfd9cf57a6cc36aeff874c96297c4b
>
>
> Diff: https://reviews.apache.org/r/71106/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jacob Janco
>
>
Re: Review Request 71106: Moved kernelVersion check to common code.
Posted by Jacob Janco <jj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71106/
-----------------------------------------------------------
(Updated July 18, 2019, 8:15 p.m.)
Review request for mesos.
Repository: mesos
Description
-------
Moved kernelVersion check to common code.
Diffs (updated)
-----
src/Makefile.am 761dde1d63e0f4f1ac4ab86f129f84f3746d3153
src/common/kernel_version.hpp PRE-CREATION
src/common/kernel_version.cpp PRE-CREATION
src/linux/ns.cpp 2440bb2232dfd9cf57a6cc36aeff874c96297c4b
Diff: https://reviews.apache.org/r/71106/diff/2/
Changes: https://reviews.apache.org/r/71106/diff/1-2/
Testing
-------
Thanks,
Jacob Janco