You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2015/06/29 10:11:04 UTC

[jira] [Commented] (HADOOP-12142) Test code modification is not detected if test directory is at the top level of the project

    [ https://issues.apache.org/jira/browse/HADOOP-12142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14605253#comment-14605253 ] 

Hadoop QA commented on HADOOP-12142:
------------------------------------

\\
\\
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s {color} | {color:blue} precommit patch detected. {color} |
| {color:blue}0{color} | {color:blue} @author {color} | {color:blue} 0m 0s {color} | {color:blue} Skipping @author checks as test-patch.sh has been patched. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 0s {color} | {color:green} Patch does not generate ASF License warnings. {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m 8s {color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 0m 12s {color} | {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12742470/HADOOP-12142.HADOOP-12111.01.patch |
| git revision | HADOOP-12111 / 8e657fb |
| Optional Tests | asflicense shellcheck |
| uname | Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Default Java | 1.7.0_55 |
| shellcheck | v0.3.3 (This is an old version that has serious bugs. Consider upgrading.) |
| Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/7077/console |


This message was automatically generated.

> Test code modification is not detected if test directory is at the top level of the project
> -------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-12142
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12142
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: yetus
>    Affects Versions: HADOOP-12111
>            Reporter: Kengo Seki
>            Assignee: Kengo Seki
>         Attachments: HADOOP-12142.HADOOP-12111.01.patch
>
>
> On HADOOP-12134, a sample patch contains test code modification, but test4tests failed to detect it.
> This is because test directory is at the top level of the Pig project. test-patch detects changed files as follows, so the pattern does not match "test/...".
> {code}
>   for i in ${CHANGED_FILES}; do
>     if [[ ${i} =~ /test/ ]]; then
>       ((testReferences=testReferences + 1))
>     fi
>   done
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)