[GitHub] [iceberg] tweise commented on a change in pull request #4060: Flink: DataIteratorBatcher that converts iterator of T to iterator of…

[GitBox <gi...@apache.org>]

tweise commented on a change in pull request #4060:
URL: https://github.com/apache/iceberg/pull/4060#discussion_r804859241



##########
File path: flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/FlinkConfigOptions.java
##########
@@ -40,4 +40,10 @@ private FlinkConfigOptions() {
           .intType()
           .defaultValue(100)
           .withDescription("Sets max infer parallelism for source operator.");
+
+  public static final ConfigOption<Integer> SOURCE_READER_FETCH_BATCH_RECORD_COUNT = ConfigOptions
+      .key("reader.fetch.batch-record-count")

Review comment:
       Please add javadoc to give some context how the options are used and maybe also wrt naming scheme.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org