You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@streampark.apache.org by "wolfboys (via GitHub)" <gi...@apache.org> on 2023/04/04 04:35:28 UTC
[GitHub] [incubator-streampark] wolfboys opened a new pull request, #2566: [Improve] Flink version check improvement
wolfboys opened a new pull request, #2566:
URL: https://github.com/apache/incubator-streampark/pull/2566
[Improve] Flink version check improvement
## What changes were proposed in this pull request
Issue Number: close #2563
<!--(For example: This pull request proposed to add checkstyle plugin).-->
## Brief change log
<!--*(for example:)*
- *Add maven-checkstyle-plugin to root pom.xml*
-->
## Verifying this change
<!--*(Please pick either of the following options)*-->
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
<!--*(example:)*
- *Added integration tests for end-to-end.*
- *Added *Test to verify the change.*
- *Manually verified the change by testing locally.* -->
## Does this pull request potentially affect one of the following parts
- Dependencies (does it add or upgrade a dependency): no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] wolfboys merged pull request #2566: [Improve] Flink version check improvement
Posted by "wolfboys (via GitHub)" <gi...@apache.org>.
wolfboys merged PR #2566:
URL: https://github.com/apache/incubator-streampark/pull/2566
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] lvshaokang commented on a diff in pull request #2566: [Improve] Flink version check improvement
Posted by "lvshaokang (via GitHub)" <gi...@apache.org>.
lvshaokang commented on code in PR #2566:
URL: https://github.com/apache/incubator-streampark/pull/2566#discussion_r1156998070
##########
streampark-common/src/main/scala/org/apache/streampark/common/conf/FlinkVersion.scala:
##########
@@ -109,6 +109,18 @@ class FlinkVersion(val flinkHome: String) extends java.io.Serializable with Logg
distJar.head
}
+ def checkVersion(throwable: Boolean = true): Boolean = {
Review Comment:
```suggestion
def checkVersion(throwException: Boolean = true): Boolean = {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] wolfboys commented on a diff in pull request #2566: [Improve] Flink version check improvement
Posted by "wolfboys (via GitHub)" <gi...@apache.org>.
wolfboys commented on code in PR #2566:
URL: https://github.com/apache/incubator-streampark/pull/2566#discussion_r1157078941
##########
streampark-common/src/main/scala/org/apache/streampark/common/conf/FlinkVersion.scala:
##########
@@ -109,6 +109,18 @@ class FlinkVersion(val flinkHome: String) extends java.io.Serializable with Logg
distJar.head
}
+ def checkVersion(throwable: Boolean = true): Boolean = {
Review Comment:
>
updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] zhoulii commented on pull request #2566: [Improve] Flink version check improvement
Posted by "zhoulii (via GitHub)" <gi...@apache.org>.
zhoulii commented on PR #2566:
URL: https://github.com/apache/incubator-streampark/pull/2566#issuecomment-1495462089
@wolfboys Nice work. Tested with flink 1.12.5/1.15.3/1.16.0/1.17.0 remote mode, it works well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] wolfboys commented on pull request #2566: [Improve] Flink version check improvement
Posted by "wolfboys (via GitHub)" <gi...@apache.org>.
wolfboys commented on PR #2566:
URL: https://github.com/apache/incubator-streampark/pull/2566#issuecomment-1495387485
cc @lvshaokang @zhoulii please review and test. thx.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org