You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "John Russell (Code Review)" <ge...@cloudera.org> on 2017/01/05 23:16:04 UTC
[Impala-ASF-CR] IMPALA-3402: Change version numbers in shared variables file.
John Russell has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5626
Change subject: IMPALA-3402: Change version numbers in shared variables file.
......................................................................
IMPALA-3402: Change version numbers in shared variables file.
Some instances of 'CDH' in the doc metadata might show up
in variable substitions or unexpected places generally,
such as the PDF title page or inside cover. Switching them
all to Impala-only numbers. Filling in Impala 2.8 as the
'current' number to reflect what will be the next release.
Change-Id: I69e855aa958a45b3286a27fa69bcf8df315fc174
---
M docs/shared/ImpalaVariables.xml
1 file changed, 17 insertions(+), 17 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/5626/1
--
To view, visit http://gerrit.cloudera.org:8080/5626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I69e855aa958a45b3286a27fa69bcf8df315fc174
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
[Impala-ASF-CR] IMPALA-3402: Change version numbers in shared variables file.
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has submitted this change and it was merged.
Change subject: IMPALA-3402: Change version numbers in shared variables file.
......................................................................
IMPALA-3402: Change version numbers in shared variables file.
Some instances of 'CDH' in the doc metadata might show up
in variable substitions or unexpected places generally,
such as the PDF title page or inside cover. Switching them
all to Impala-only numbers. Filling in Impala 2.8 as the
'current' number to reflect what will be the next release.
Also remove another instance of 'Cloudera' in the title.
Change-Id: I69e855aa958a45b3286a27fa69bcf8df315fc174
Reviewed-on: http://gerrit.cloudera.org:8080/5626
Reviewed-by: Jim Apple <jb...@apache.org>
Tested-by: John Russell <jr...@cloudera.com>
---
M docs/shared/ImpalaVariables.xml
1 file changed, 18 insertions(+), 18 deletions(-)
Approvals:
Jim Apple: Looks good to me, approved
John Russell: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I69e855aa958a45b3286a27fa69bcf8df315fc174
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #250
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
[Impala-ASF-CR] IMPALA-3402: Change version numbers in shared variables file.
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: IMPALA-3402: Change version numbers in shared variables file.
......................................................................
Patch Set 1:
(1 comment)
Just making a little followup change that I'll post as patch set 2 momentarily.
http://gerrit.cloudera.org:8080/#/c/5626/1/docs/shared/ImpalaVariables.xml
File docs/shared/ImpalaVariables.xml:
PS1, Line 22: Cloudera
Ambreen pointed out this unnecessary (invisible to readers) instance of 'Cloudera'. Why don't I take it out in this code review rather than making a separate CR.
--
To view, visit http://gerrit.cloudera.org:8080/5626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I69e855aa958a45b3286a27fa69bcf8df315fc174
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #250
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3402: Change version numbers in shared variables file.
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: IMPALA-3402: Change version numbers in shared variables file.
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I69e855aa958a45b3286a27fa69bcf8df315fc174
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #250
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3402: Change version numbers in shared variables file.
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: IMPALA-3402: Change version numbers in shared variables file.
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5626/1/docs/shared/ImpalaVariables.xml
File docs/shared/ImpalaVariables.xml:
PS1, Line 22: Cloudera
> Ambreen pointed out this unnecessary (invisible to readers) instance of 'Cl
Done
--
To view, visit http://gerrit.cloudera.org:8080/5626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I69e855aa958a45b3286a27fa69bcf8df315fc174
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #250
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3402: Change version numbers in shared variables file.
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: IMPALA-3402: Change version numbers in shared variables file.
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I69e855aa958a45b3286a27fa69bcf8df315fc174
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #250
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3402: Change version numbers in shared variables file.
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
Hello Jim Apple,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5626
to look at the new patch set (#2).
Change subject: IMPALA-3402: Change version numbers in shared variables file.
......................................................................
IMPALA-3402: Change version numbers in shared variables file.
Some instances of 'CDH' in the doc metadata might show up
in variable substitions or unexpected places generally,
such as the PDF title page or inside cover. Switching them
all to Impala-only numbers. Filling in Impala 2.8 as the
'current' number to reflect what will be the next release.
Also remove another instance of 'Cloudera' in the title.
Change-Id: I69e855aa958a45b3286a27fa69bcf8df315fc174
---
M docs/shared/ImpalaVariables.xml
1 file changed, 18 insertions(+), 18 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/5626/2
--
To view, visit http://gerrit.cloudera.org:8080/5626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I69e855aa958a45b3286a27fa69bcf8df315fc174
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #250
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
[Impala-ASF-CR] IMPALA-3402: Change version numbers in shared variables file.
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: IMPALA-3402: Change version numbers in shared variables file.
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/5626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I69e855aa958a45b3286a27fa69bcf8df315fc174
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #250
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No