You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/01/12 13:18:57 UTC
[GitHub] [dubbo-samples] superalong opened a new pull request #253: Dubbo smaples reactor grpc test case conversion
superalong opened a new pull request #253:
URL: https://github.com/apache/dubbo-samples/pull/253
Dubbo smaples reactor grpc test case conversion
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] kylixs commented on pull request #253: Dubbo smaples reactor grpc test case conversion
Posted by GitBox <gi...@apache.org>.
kylixs commented on pull request #253:
URL: https://github.com/apache/dubbo-samples/pull/253#issuecomment-760267735
还是要看完这个文档，特别是依赖管理的部分 https://github.com/apache/dubbo-samples/blob/master/test/convert-case.md#maven%E9%85%8D%E7%BD%AE%E4%BC%98%E5%8C%96
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] kylixs commented on a change in pull request #253: Dubbo smaples reactor grpc test case conversion
Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #253:
URL: https://github.com/apache/dubbo-samples/pull/253#discussion_r555794019
##########
File path: dubbo-samples-grpc/dubbo-samples-reactor/pom.xml
##########
@@ -104,13 +99,6 @@
<version>${spring-test.version}</version>
Review comment:
spring-test 改成 dependencyManagement管理版本，请参考文档 https://github.com/apache/dubbo-samples/blob/master/test/convert-case.md#maven%E9%85%8D%E7%BD%AE%E4%BC%98%E5%8C%96
##########
File path: dubbo-samples-grpc/dubbo-samples-reactor/pom.xml
##########
@@ -35,11 +35,6 @@
<jib-maven-plugin.version>1.2.0</jib-maven-plugin.version>
<maven-compiler-plugin.version>3.7.0</maven-compiler-plugin.version>
<maven-failsafe-plugin.version>2.21.0</maven-failsafe-plugin.version>
Review comment:
jib, failsafe等不使用的插件的版本号去掉
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] kylixs commented on a change in pull request #253: Dubbo smaples reactor grpc test case conversion
Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #253:
URL: https://github.com/apache/dubbo-samples/pull/253#discussion_r557479153
##########
File path: dubbo-samples-grpc/dubbo-samples-reactor/pom.xml
##########
@@ -28,116 +28,132 @@
<properties>
<source.level>1.8</source.level>
<target.level>1.8</target.level>
+ <maven-compiler-plugin.version>3.7.0</maven-compiler-plugin.version>
+ <protobuf.version>3.6.1</protobuf.version>
<dubbo.version>2.7.7</dubbo.version>
<junit.version>4.12</junit.version>
<spring-test.version>4.3.16.RELEASE</spring-test.version>
- <docker-maven-plugin.version>0.30.0</docker-maven-plugin.version>
- <jib-maven-plugin.version>1.2.0</jib-maven-plugin.version>
- <maven-compiler-plugin.version>3.7.0</maven-compiler-plugin.version>
- <maven-failsafe-plugin.version>2.21.0</maven-failsafe-plugin.version>
- <image.name>${project.artifactId}:${dubbo.version}</image.name>
- <java-image.name>openjdk:8</java-image.name>
- <dubbo.port>20880</dubbo.port>
- <zookeeper.port>2181</zookeeper.port>
- <main-class>org.apache.dubbo.samples.basic.BasicProvider</main-class>
<spring-boot.version>1.5.13.RELEASE</spring-boot.version>
<grpc.version>1.19.0</grpc.version>
<dubbo.compiler.version>0.0.1</dubbo.compiler.version>
<reactive.grpc.version>1.0.0</reactive.grpc.version>
</properties>
+ <dependencyManagement>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.dubbo</groupId>
+ <artifactId>dubbo</artifactId>
Review comment:
用dubbo-bom管理dubbo组件版本，不要加dubbo的依赖
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] AlbumenJ merged pull request #253: Dubbo smaples reactor grpc test case conversion
Posted by GitBox <gi...@apache.org>.
AlbumenJ merged pull request #253:
URL: https://github.com/apache/dubbo-samples/pull/253
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] kylixs commented on a change in pull request #253: Dubbo smaples reactor grpc test case conversion
Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #253:
URL: https://github.com/apache/dubbo-samples/pull/253#discussion_r557476217
##########
File path: dubbo-samples-grpc/dubbo-samples-reactor/pom.xml
##########
@@ -28,116 +28,132 @@
<properties>
<source.level>1.8</source.level>
<target.level>1.8</target.level>
+ <maven-compiler-plugin.version>3.7.0</maven-compiler-plugin.version>
+ <protobuf.version>3.6.1</protobuf.version>
<dubbo.version>2.7.7</dubbo.version>
<junit.version>4.12</junit.version>
<spring-test.version>4.3.16.RELEASE</spring-test.version>
- <docker-maven-plugin.version>0.30.0</docker-maven-plugin.version>
- <jib-maven-plugin.version>1.2.0</jib-maven-plugin.version>
- <maven-compiler-plugin.version>3.7.0</maven-compiler-plugin.version>
- <maven-failsafe-plugin.version>2.21.0</maven-failsafe-plugin.version>
- <image.name>${project.artifactId}:${dubbo.version}</image.name>
- <java-image.name>openjdk:8</java-image.name>
- <dubbo.port>20880</dubbo.port>
- <zookeeper.port>2181</zookeeper.port>
- <main-class>org.apache.dubbo.samples.basic.BasicProvider</main-class>
<spring-boot.version>1.5.13.RELEASE</spring-boot.version>
<grpc.version>1.19.0</grpc.version>
<dubbo.compiler.version>0.0.1</dubbo.compiler.version>
<reactive.grpc.version>1.0.0</reactive.grpc.version>
</properties>
+ <dependencyManagement>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.dubbo</groupId>
+ <artifactId>dubbo</artifactId>
+ <version>${dubbo.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>io.grpc</groupId>
+ <artifactId>grpc-netty</artifactId>
+ <version>${grpc.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>io.grpc</groupId>
+ <artifactId>grpc-netty-shaded</artifactId>
+ <version>${grpc.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>io.grpc</groupId>
+ <artifactId>grpc-protobuf</artifactId>
+ <version>${grpc.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>io.grpc</groupId>
+ <artifactId>grpc-stub</artifactId>
+ <version>${grpc.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>com.google.protobuf</groupId>
+ <artifactId>protobuf-java-util</artifactId>
+ <version>${protobuf.version}</version>
+ </dependency>
+
+ <dependency>
+ <groupId>com.salesforce.servicelibs</groupId>
+ <artifactId>reactor-grpc-stub</artifactId>
+ <version>${reactive.grpc.version}</version>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.dubbo</groupId>
+ <artifactId>dubbo-dependencies-zookeeper</artifactId>
+ <version>${dubbo.version}</version>
+ <type>pom</type>
+ </dependency>
+
+ <dependency>
+ <groupId>junit</groupId>
+ <artifactId>junit</artifactId>
+ <version>${junit.version}</version>
+ <scope>test</scope>
+ </dependency>
+
+ <dependency>
+ <groupId>org.springframework</groupId>
+ <artifactId>spring-test</artifactId>
Review comment:
不需要加spring-test的依赖，统一用spring framwork bom管理
##########
File path: dubbo-samples-grpc/dubbo-samples-reactor/pom.xml
##########
@@ -28,116 +28,132 @@
<properties>
<source.level>1.8</source.level>
<target.level>1.8</target.level>
+ <maven-compiler-plugin.version>3.7.0</maven-compiler-plugin.version>
Review comment:
maven-compiler-plugin.version 这个不需要抽取版本号
##########
File path: dubbo-samples-grpc/dubbo-samples-reactor/pom.xml
##########
@@ -28,116 +28,132 @@
<properties>
<source.level>1.8</source.level>
<target.level>1.8</target.level>
+ <maven-compiler-plugin.version>3.7.0</maven-compiler-plugin.version>
+ <protobuf.version>3.6.1</protobuf.version>
<dubbo.version>2.7.7</dubbo.version>
<junit.version>4.12</junit.version>
<spring-test.version>4.3.16.RELEASE</spring-test.version>
- <docker-maven-plugin.version>0.30.0</docker-maven-plugin.version>
- <jib-maven-plugin.version>1.2.0</jib-maven-plugin.version>
- <maven-compiler-plugin.version>3.7.0</maven-compiler-plugin.version>
- <maven-failsafe-plugin.version>2.21.0</maven-failsafe-plugin.version>
- <image.name>${project.artifactId}:${dubbo.version}</image.name>
- <java-image.name>openjdk:8</java-image.name>
- <dubbo.port>20880</dubbo.port>
- <zookeeper.port>2181</zookeeper.port>
- <main-class>org.apache.dubbo.samples.basic.BasicProvider</main-class>
<spring-boot.version>1.5.13.RELEASE</spring-boot.version>
<grpc.version>1.19.0</grpc.version>
<dubbo.compiler.version>0.0.1</dubbo.compiler.version>
<reactive.grpc.version>1.0.0</reactive.grpc.version>
</properties>
+ <dependencyManagement>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.dubbo</groupId>
+ <artifactId>dubbo</artifactId>
+ <version>${dubbo.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>io.grpc</groupId>
+ <artifactId>grpc-netty</artifactId>
+ <version>${grpc.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>io.grpc</groupId>
+ <artifactId>grpc-netty-shaded</artifactId>
+ <version>${grpc.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>io.grpc</groupId>
+ <artifactId>grpc-protobuf</artifactId>
+ <version>${grpc.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>io.grpc</groupId>
+ <artifactId>grpc-stub</artifactId>
+ <version>${grpc.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>com.google.protobuf</groupId>
+ <artifactId>protobuf-java-util</artifactId>
+ <version>${protobuf.version}</version>
Review comment:
protobuf-java-util 不需要抽取版本号属性
##########
File path: dubbo-samples-grpc/dubbo-samples-reactor/pom.xml
##########
@@ -28,116 +28,132 @@
<properties>
<source.level>1.8</source.level>
<target.level>1.8</target.level>
+ <maven-compiler-plugin.version>3.7.0</maven-compiler-plugin.version>
+ <protobuf.version>3.6.1</protobuf.version>
<dubbo.version>2.7.7</dubbo.version>
<junit.version>4.12</junit.version>
<spring-test.version>4.3.16.RELEASE</spring-test.version>
- <docker-maven-plugin.version>0.30.0</docker-maven-plugin.version>
- <jib-maven-plugin.version>1.2.0</jib-maven-plugin.version>
- <maven-compiler-plugin.version>3.7.0</maven-compiler-plugin.version>
- <maven-failsafe-plugin.version>2.21.0</maven-failsafe-plugin.version>
- <image.name>${project.artifactId}:${dubbo.version}</image.name>
- <java-image.name>openjdk:8</java-image.name>
- <dubbo.port>20880</dubbo.port>
- <zookeeper.port>2181</zookeeper.port>
- <main-class>org.apache.dubbo.samples.basic.BasicProvider</main-class>
<spring-boot.version>1.5.13.RELEASE</spring-boot.version>
<grpc.version>1.19.0</grpc.version>
<dubbo.compiler.version>0.0.1</dubbo.compiler.version>
<reactive.grpc.version>1.0.0</reactive.grpc.version>
</properties>
+ <dependencyManagement>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.dubbo</groupId>
+ <artifactId>dubbo</artifactId>
+ <version>${dubbo.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>io.grpc</groupId>
+ <artifactId>grpc-netty</artifactId>
+ <version>${grpc.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>io.grpc</groupId>
+ <artifactId>grpc-netty-shaded</artifactId>
+ <version>${grpc.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>io.grpc</groupId>
+ <artifactId>grpc-protobuf</artifactId>
+ <version>${grpc.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>io.grpc</groupId>
+ <artifactId>grpc-stub</artifactId>
+ <version>${grpc.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>com.google.protobuf</groupId>
+ <artifactId>protobuf-java-util</artifactId>
+ <version>${protobuf.version}</version>
+ </dependency>
+
+ <dependency>
+ <groupId>com.salesforce.servicelibs</groupId>
+ <artifactId>reactor-grpc-stub</artifactId>
+ <version>${reactive.grpc.version}</version>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.dubbo</groupId>
+ <artifactId>dubbo-dependencies-zookeeper</artifactId>
+ <version>${dubbo.version}</version>
+ <type>pom</type>
+ </dependency>
+
+ <dependency>
+ <groupId>junit</groupId>
+ <artifactId>junit</artifactId>
+ <version>${junit.version}</version>
+ <scope>test</scope>
+ </dependency>
+
+ <dependency>
+ <groupId>org.springframework</groupId>
+ <artifactId>spring-test</artifactId>
+ <version>${spring-test.version}</version>
+ <scope>test</scope>
+ </dependency>
+ </dependencies>
+ </dependencyManagement>
+
<dependencies>
<dependency>
<groupId>org.apache.dubbo</groupId>
<artifactId>dubbo</artifactId>
- <version>${dubbo.version}</version>
</dependency>
<dependency>
<groupId>io.grpc</groupId>
<artifactId>grpc-netty</artifactId>
- <version>${grpc.version}</version>
</dependency>
<dependency>
<groupId>io.grpc</groupId>
<artifactId>grpc-netty-shaded</artifactId>
- <version>${grpc.version}</version>
</dependency>
<dependency>
<groupId>io.grpc</groupId>
<artifactId>grpc-protobuf</artifactId>
- <version>${grpc.version}</version>
</dependency>
<dependency>
<groupId>io.grpc</groupId>
<artifactId>grpc-stub</artifactId>
- <version>${grpc.version}</version>
</dependency>
<dependency>
<groupId>com.google.protobuf</groupId>
<artifactId>protobuf-java-util</artifactId>
- <version>3.6.1</version>
</dependency>
<dependency>
<groupId>com.salesforce.servicelibs</groupId>
<artifactId>reactor-grpc-stub</artifactId>
- <version>${reactive.grpc.version}</version>
</dependency>
<dependency>
<groupId>org.apache.dubbo</groupId>
<artifactId>dubbo-dependencies-zookeeper</artifactId>
- <version>${dubbo.version}</version>
<type>pom</type>
</dependency>
<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
- <version>${junit.version}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.springframework</groupId>
<artifactId>spring-test</artifactId>
- <version>${spring-test.version}</version>
- <scope>test</scope>
- </dependency>
-
- <dependency>
- <groupId>org.testcontainers</groupId>
- <artifactId>testcontainers</artifactId>
- <version>1.12.3</version>
<scope>test</scope>
</dependency>
</dependencies>
<profiles>
<profile>
<id>dubbo-integration-test</id>
Review comment:
这个profile删除掉 dubbo-integration-test
##########
File path: dubbo-samples-grpc/dubbo-samples-reactor/pom.xml
##########
@@ -28,116 +28,132 @@
<properties>
<source.level>1.8</source.level>
<target.level>1.8</target.level>
+ <maven-compiler-plugin.version>3.7.0</maven-compiler-plugin.version>
+ <protobuf.version>3.6.1</protobuf.version>
<dubbo.version>2.7.7</dubbo.version>
<junit.version>4.12</junit.version>
<spring-test.version>4.3.16.RELEASE</spring-test.version>
- <docker-maven-plugin.version>0.30.0</docker-maven-plugin.version>
- <jib-maven-plugin.version>1.2.0</jib-maven-plugin.version>
- <maven-compiler-plugin.version>3.7.0</maven-compiler-plugin.version>
- <maven-failsafe-plugin.version>2.21.0</maven-failsafe-plugin.version>
- <image.name>${project.artifactId}:${dubbo.version}</image.name>
- <java-image.name>openjdk:8</java-image.name>
- <dubbo.port>20880</dubbo.port>
- <zookeeper.port>2181</zookeeper.port>
- <main-class>org.apache.dubbo.samples.basic.BasicProvider</main-class>
<spring-boot.version>1.5.13.RELEASE</spring-boot.version>
<grpc.version>1.19.0</grpc.version>
<dubbo.compiler.version>0.0.1</dubbo.compiler.version>
<reactive.grpc.version>1.0.0</reactive.grpc.version>
</properties>
+ <dependencyManagement>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.dubbo</groupId>
+ <artifactId>dubbo</artifactId>
+ <version>${dubbo.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>io.grpc</groupId>
+ <artifactId>grpc-netty</artifactId>
+ <version>${grpc.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>io.grpc</groupId>
+ <artifactId>grpc-netty-shaded</artifactId>
+ <version>${grpc.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>io.grpc</groupId>
+ <artifactId>grpc-protobuf</artifactId>
+ <version>${grpc.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>io.grpc</groupId>
+ <artifactId>grpc-stub</artifactId>
+ <version>${grpc.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>com.google.protobuf</groupId>
+ <artifactId>protobuf-java-util</artifactId>
+ <version>${protobuf.version}</version>
+ </dependency>
+
+ <dependency>
+ <groupId>com.salesforce.servicelibs</groupId>
+ <artifactId>reactor-grpc-stub</artifactId>
+ <version>${reactive.grpc.version}</version>
Review comment:
reactor-grpc-stub 不要抽取版本号属性
##########
File path: dubbo-samples-grpc/dubbo-samples-reactor/pom.xml
##########
@@ -28,116 +28,132 @@
<properties>
<source.level>1.8</source.level>
<target.level>1.8</target.level>
+ <maven-compiler-plugin.version>3.7.0</maven-compiler-plugin.version>
+ <protobuf.version>3.6.1</protobuf.version>
<dubbo.version>2.7.7</dubbo.version>
<junit.version>4.12</junit.version>
<spring-test.version>4.3.16.RELEASE</spring-test.version>
- <docker-maven-plugin.version>0.30.0</docker-maven-plugin.version>
- <jib-maven-plugin.version>1.2.0</jib-maven-plugin.version>
- <maven-compiler-plugin.version>3.7.0</maven-compiler-plugin.version>
- <maven-failsafe-plugin.version>2.21.0</maven-failsafe-plugin.version>
- <image.name>${project.artifactId}:${dubbo.version}</image.name>
- <java-image.name>openjdk:8</java-image.name>
- <dubbo.port>20880</dubbo.port>
- <zookeeper.port>2181</zookeeper.port>
- <main-class>org.apache.dubbo.samples.basic.BasicProvider</main-class>
<spring-boot.version>1.5.13.RELEASE</spring-boot.version>
<grpc.version>1.19.0</grpc.version>
<dubbo.compiler.version>0.0.1</dubbo.compiler.version>
<reactive.grpc.version>1.0.0</reactive.grpc.version>
</properties>
+ <dependencyManagement>
+ <dependencies>
+ <dependency>
Review comment:
添加spring framwork bom的依赖
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] AlbumenJ merged pull request #253: Dubbo smaples reactor grpc test case conversion
Posted by GitBox <gi...@apache.org>.
AlbumenJ merged pull request #253:
URL: https://github.com/apache/dubbo-samples/pull/253
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org