[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #6520: Improve error messages with function name suggestion.

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on code in PR #6520:
URL: https://github.com/apache/arrow-datafusion/pull/6520#discussion_r1215728844


##########
datafusion/common/src/utils.rs:
##########
@@ -318,6 +318,74 @@ impl<T: ?Sized> DataPtr for Arc<T> {
     }
 }
 
+/// Adopted from strsim-rs for string similarity metrics
+pub mod datafusion_strsim {
+    // Source: https://github.com/dguo/strsim-rs/blob/master/src/lib.rs

Review Comment:
   👍  thank you for the link



##########
datafusion/common/src/utils.rs:
##########
@@ -383,7 +377,7 @@ pub mod datafusion_strsim {
     /// required to change one string into the other.
     ///
     /// ```
-    /// use strsim::levenshtein;
+    /// use datafusion_common::utils::datafusion_strsim::levenshtein;

Review Comment:
   👍 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org