You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@quickstep.apache.org by cramja <gi...@git.apache.org> on 2017/03/16 22:13:21 UTC
[GitHub] incubator-quickstep pull request #213: Added script for release license audi...
GitHub user cramja opened a pull request:
https://github.com/apache/incubator-quickstep/pull/213
Added script for release license audit
@hbdeshmukh Take a look, this will be useful in the future.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cramja/incubator-quickstep release-audit-script
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-quickstep/pull/213.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #213
----
commit 97129bc145bbcf030cd3646c725232443e18f9fa
Author: cramja <ma...@gmail.com>
Date: 2017-03-16T22:12:37Z
Added script for release license audit
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #213: Added script for release license audit
Posted by cramja <gi...@git.apache.org>.
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/213
Sure, also I merged while doing that. I think it's kosher so long as someone looked over the PR w/ a +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #213: Added script for release license audit
Posted by hbdeshmukh <gi...@git.apache.org>.
Github user hbdeshmukh commented on the issue:
https://github.com/apache/incubator-quickstep/pull/213
Hi @cramja your fork is behind the master. Can you please sync it? Then I can merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep pull request #213: Added script for release license audi...
Posted by hbdeshmukh <gi...@git.apache.org>.
Github user hbdeshmukh commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/213#discussion_r106575102
--- Diff: release/release_cmds.sh ---
@@ -100,6 +101,23 @@ publish_candidate() {
cd $BASE_DIR
}
+release_audit() {
+ # Downloads/runs the apache Release Audit Tool on the base folder, excluding this
+ # release directory
+ #
+ if [ ! -d apache-rat-0.12 ] ; then
+ curl http://apache.spinellicreations.com//creadur/apache-rat-0.12/apache-rat-0.12-bin.tar.bz2 > rat.tar.bz2
+ tar -xzf rat.tar.bz2
+ rm rat.tar.bz2
+ fi
+ java -jar apache-rat-0.12/apache-rat-0.12.jar -e release -e build -e cmake* -d .. > rat-report.txt
+ if [ $? == 0 ] ; then
+ echo "created rat-report.txt"
+ else
+ echo "error running rat"
+ fi
--- End diff --
Do you think we should delete the rat source code after we are done using it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep pull request #213: Added script for release license audi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/213
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep pull request #213: Added script for release license audi...
Posted by cramja <gi...@git.apache.org>.
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/213#discussion_r106544574
--- Diff: release/release_cmds.sh ---
@@ -50,14 +51,14 @@ create_artifacts() {
# Make the signature. This requires human input
gpg -u $APACHE_USERNAME@apache.org --armor --output $PROJECT_NAME-$VERSION.tar.gz.asc --detach-sign $PROJECT_NAME-$VERSION.tar.gz
# Make hashes
+ for algo in 256 512; do
+ shasum -a $algo $PROJECT_NAME-$VERSION.tar.gz > $PROJECT_NAME-$VERSION.tar.gz.sha$algo
--- End diff --
@hbdeshmukh PS, I added these changes in this PR as well. We now will use un-cracked versions of SHA \U0001f604
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep pull request #213: Added script for release license audi...
Posted by cramja <gi...@git.apache.org>.
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/213#discussion_r106643961
--- Diff: release/release_cmds.sh ---
@@ -100,6 +101,23 @@ publish_candidate() {
cd $BASE_DIR
}
+release_audit() {
+ # Downloads/runs the apache Release Audit Tool on the base folder, excluding this
+ # release directory
+ #
+ if [ ! -d apache-rat-0.12 ] ; then
+ curl http://apache.spinellicreations.com//creadur/apache-rat-0.12/apache-rat-0.12-bin.tar.bz2 > rat.tar.bz2
+ tar -xzf rat.tar.bz2
+ rm rat.tar.bz2
+ fi
+ java -jar apache-rat-0.12/apache-rat-0.12.jar -e release -e build -e cmake* -d .. > rat-report.txt
+ if [ $? == 0 ] ; then
+ echo "created rat-report.txt"
+ else
+ echo "error running rat"
+ fi
--- End diff --
It's a jar - like a java executable. I think it's fine to keep around seeing as gitignore already ignores it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #213: Added script for release license audit
Posted by hbdeshmukh <gi...@git.apache.org>.
Github user hbdeshmukh commented on the issue:
https://github.com/apache/incubator-quickstep/pull/213
Looks good to me, the audit feature should be really useful.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---