You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/02/17 19:46:28 UTC

[GitHub] [orc] dongjoon-hyun commented on a change in pull request #476: ORC-40: [C++] Implement Predicate Pushdown for C++ Reader

dongjoon-hyun commented on a change in pull request #476:
URL: https://github.com/apache/orc/pull/476#discussion_r577896311



##########
File path: c++/src/Reader.hh
##########
@@ -19,13 +19,14 @@
 #ifndef ORC_READER_IMPL_HH
 #define ORC_READER_IMPL_HH
 
+#include "orc/Exceptions.hh"
 #include "orc/Int128.hh"
 #include "orc/OrcFile.hh"
 #include "orc/Reader.hh"
 
 #include "ColumnReader.hh"
-#include "orc/Exceptions.hh"

Review comment:
       The move from line 27 to 22 looks reasonable. BTW, do we have a C++ convention for `C++ include` statement order?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org