You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/08/29 21:39:37 UTC

[GitHub] [fineract] vorburger commented on pull request #1299: FINERACT-1129: create Gradle release task - fix source distribution

vorburger commented on pull request #1299:
URL: https://github.com/apache/fineract/pull/1299#issuecomment-683344781


   I believe it would be better for the project if we (all), generally, would not "self merge" our own PRs, before they have received review feedback from others, but have active committer review and merge (or self merge after LGTM/s from committers). 
   
   Perhaps this would be worth to be spelt out as a Best Practice in the README, what do you think @ptuomola @thesmallstar et al?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org