You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by ra...@apache.org on 2016/11/02 09:14:32 UTC

[4/4] git commit: updated refs/heads/master to f7733b4

Merge pull request #1600 from syed/snapshot-archive-pr

Support Backup of Snapshots for Managed Storage```
This PR adds an ability to Pass a new parameter, locationType,
to the createSnapshot API command. Depending on the locationType,
we decide where the snapshot should go in case of managed storage.

There are two possible values for the locationType param

1) `Primary`: The standard operation for managed storage is to
keep the snapshot on the device (primary). For non-managed storage, this will
give an error as this option is only supported for managed storage

2) `Secondary`: Applicable only to managed storage. This will
keep the snapshot on the secondary storage. For non-managed
storage, this will result in an error.

The reason for implementing this feature is to avoid a single
point of failure for primary storage. Right now in case of managed
storage, if the primary storage goes down, there is no easy way
to recover data as all snapshots are also stored on the primary.
This features allows us to mitigate that risk.
```

* pr/1600:
  Support Backup of Snapshots for Managed Storage

Signed-off-by: Rajani Karuturi <ra...@accelerite.com>


Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/f7733b4a
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/f7733b4a
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/f7733b4a

Branch: refs/heads/master
Commit: f7733b4a0eaee1391f015c7f0a500cf6b9a38ddc
Parents: f71aadb f46651e
Author: Rajani Karuturi <ra...@accelerite.com>
Authored: Wed Nov 2 14:43:43 2016 +0530
Committer: Rajani Karuturi <ra...@accelerite.com>
Committed: Wed Nov 2 14:43:43 2016 +0530

----------------------------------------------------------------------
 api/src/com/cloud/storage/Snapshot.java         |  12 +-
 api/src/com/cloud/storage/VolumeApiService.java |   8 +-
 .../storage/snapshot/SnapshotApiService.java    |   2 +-
 .../org/apache/cloudstack/api/ApiConstants.java |   1 +
 .../user/snapshot/CreateSnapshotCmd.java        |  56 ++-
 .../api/response/SnapshotResponse.java          |  18 +-
 .../api/command/test/CreateSnapshotCmdTest.java | 132 ++++++
 .../storage/to/PrimaryDataStoreTO.java          |  13 +-
 .../subsystem/api/storage/SnapshotResult.java   |  12 +-
 .../com/cloud/vm/VmWorkTakeVolumeSnapshot.java  |   8 +-
 .../src/com/cloud/storage/SnapshotVO.java       |  29 +-
 .../motion/StorageSystemDataMotionStrategy.java | 424 +++++++++++++++----
 .../storage/snapshot/SnapshotObject.java        |   3 +
 .../storage/snapshot/SnapshotServiceImpl.java   |   2 +-
 .../storage/snapshot/SnapshotStrategyBase.java  |   2 +-
 .../snapshot/StorageSystemSnapshotStrategy.java | 148 +++++--
 .../snapshot/XenserverSnapshotStrategy.java     |   4 +-
 .../image/db/SnapshotDataStoreDaoImpl.java      |  37 +-
 .../storage/snapshot/SnapshotEntityImpl.java    |   5 +
 .../xenserver/resource/CitrixResourceBase.java  | 378 +++++++++--------
 .../resource/XenServerStorageProcessor.java     |  77 ++--
 .../resource/Xenserver625StorageProcessor.java  | 102 +++--
 .../CitrixResizeVolumeCommandWrapper.java       |   2 +-
 server/src/com/cloud/api/ApiDBUtils.java        |   6 +
 server/src/com/cloud/api/ApiResponseHelper.java |   1 +
 server/src/com/cloud/configuration/Config.java  |  17 +-
 .../configuration/ConfigurationManagerImpl.java |   1 +
 .../cloud/storage/CreateSnapshotPayload.java    |   8 +-
 .../com/cloud/storage/VolumeApiServiceImpl.java | 181 ++++----
 .../storage/snapshot/SnapshotManagerImpl.java   |  95 +++--
 .../cloud/storage/VolumeApiServiceImplTest.java | 117 +++--
 .../storage/snapshot/SnapshotManagerTest.java   |  71 ++--
 .../resource/NfsSecondaryStorageResource.java   | 227 +++++-----
 setup/db/db/schema-481to490.sql                 |   2 +
 tools/marvin/marvin/lib/base.py                 |   7 +-
 35 files changed, 1463 insertions(+), 745 deletions(-)
----------------------------------------------------------------------