You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by rob05c <gi...@git.apache.org> on 2017/05/26 16:50:24 UTC

[GitHub] incubator-trafficcontrol pull request #620: Add Golang log nil logger suppor...

GitHub user rob05c opened a pull request:

    https://github.com/apache/incubator-trafficcontrol/pull/620

    Add Golang log nil logger support, for performance

    From profiling, the log `Format(timeFormat)` call is expensive, and
    incurred even for null loggers. This allows applications to set null
    loggers to be nil, instead of ioutil.Discard, for better performance.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rob05c/incubator-trafficcontrol tm2-nilloggers

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-trafficcontrol/pull/620.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #620
    
----
commit 91545c7c00c82440f6fc2bbe69a49643b5ab8558
Author: Robert Butts <ro...@gmail.com>
Date:   2017-05-26T16:46:48Z

    Add log nil logger support, for performance
    
    From profiling, the log `Format(timeFormat)` call is expensive, and
    incurred even for null loggers. This allows applications to set null
    loggers to be nil, instead of ioutil.Discard, for better performance.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #620: Add Golang log nil logger suppor...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-trafficcontrol/pull/620


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---