[GitHub] [ozone] fapifta commented on pull request #2521: HDDS-5600. Allow nested blocks in switch case statements in checkstyle checks.

[GitBox <gi...@apache.org>]

fapifta commented on pull request #2521:
URL: https://github.com/apache/ozone/pull/2521#issuecomment-896124501


   @adoroszlai I think you have pointed out really well why we do not want this change afterall...
   
   In case there is a need to have local variables and a code block, one can always define a method and call that from the case or default branch of the switch statement, and it is probably a way more better practice when the code inside the branch is complicated or longer. I am revoking the PR and will add this learning point of mine in the JIRA.
   Thank you for the reviews!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org