You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by li...@apache.org on 2016/11/29 04:25:36 UTC
spark git commit: [SPARK-16282][SQL] Follow-up: remove "percentile"
from temp function detection after implementing it natively
Repository: spark
Updated Branches:
refs/heads/master 71352c94a -> e64a2047e
[SPARK-16282][SQL] Follow-up: remove "percentile" from temp function detection after implementing it natively
## What changes were proposed in this pull request?
In #15764 we added a mechanism to detect if a function is temporary or not. Hive functions are treated as non-temporary. Of the three hive functions, now "percentile" has been implemented natively, and "hash" has been removed. So we should update the list.
## How was this patch tested?
Unit tests.
Author: Shuai Lin <li...@gmail.com>
Closes #16049 from lins05/update-temp-function-detect-hive-list.
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/e64a2047
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/e64a2047
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/e64a2047
Branch: refs/heads/master
Commit: e64a2047eaf02d65dcf98b6e0710e10196aa74b1
Parents: 71352c9
Author: Shuai Lin <li...@gmail.com>
Authored: Mon Nov 28 20:23:48 2016 -0800
Committer: gatorsmile <ga...@gmail.com>
Committed: Mon Nov 28 20:23:48 2016 -0800
----------------------------------------------------------------------
.../org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala | 5 +----
.../apache/spark/sql/catalyst/catalog/SessionCatalogSuite.scala | 1 -
2 files changed, 1 insertion(+), 5 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/e64a2047/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
----------------------------------------------------------------------
diff --git a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
index 002aecb..0b6a91f 100644
--- a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
+++ b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
@@ -939,10 +939,7 @@ class SessionCatalog(
*/
def isTemporaryFunction(name: FunctionIdentifier): Boolean = {
// copied from HiveSessionCatalog
- val hiveFunctions = Seq(
- "hash",
- "histogram_numeric",
- "percentile")
+ val hiveFunctions = Seq("histogram_numeric")
// A temporary function is a function that has been registered in functionRegistry
// without a database name, and is neither a built-in function nor a Hive function
http://git-wip-us.apache.org/repos/asf/spark/blob/e64a2047/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalogSuite.scala
----------------------------------------------------------------------
diff --git a/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalogSuite.scala b/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalogSuite.scala
index da41d36..3f27160 100644
--- a/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalogSuite.scala
+++ b/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalogSuite.scala
@@ -981,7 +981,6 @@ class SessionCatalogSuite extends SparkFunSuite {
assert(FunctionRegistry.builtin.functionExists("sum"))
assert(!sessionCatalog.isTemporaryFunction(FunctionIdentifier("sum")))
assert(!sessionCatalog.isTemporaryFunction(FunctionIdentifier("histogram_numeric")))
- assert(!sessionCatalog.isTemporaryFunction(FunctionIdentifier("percentile")))
}
test("drop function") {
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org