You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "wForget (via GitHub)" <gi...@apache.org> on 2024/08/22 05:49:35 UTC

[PR] [#2077] Check java version in release scripts [incubator-uniffle]

wForget opened a new pull request, #2078:
URL: https://github.com/apache/incubator-uniffle/pull/2078

   <!--
   1. Title: [#<issue>] <type>(<scope>): <subject>
      Examples:
        - "[#123] feat(operator): support xxx"
        - "[#233] fix: check null before access result in xxx"
        - "[MINOR] refactor: fix typo in variable name"
        - "[MINOR] docs: fix typo in README"
        - "[#255] test: fix flaky test NameOfTheTest"
      Reference: https://www.conventionalcommits.org/en/v1.0.0/
   2. Contributor guidelines:
      https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
   3. If the PR is unfinished, please mark this PR as draft.
   -->
   
   ### What changes were proposed in this pull request?
   
   Check java version in release scripts
   
   ### Why are the changes needed?
   
   Use a fixed java version in the release scripts
   
   Fix: #2077
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   Manual test:
   
   Use mismatched java version:
   ```
   ./release/create-package.sh binary
   ```
   output:
   ```
   Unexpected Java version: 17.0.10. Java 8 is required for release.
   ```
   
   When using matched Java version, release scripts execute successfully.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [#2077] improvement: Check java version in release scripts [incubator-uniffle]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #2078:
URL: https://github.com/apache/incubator-uniffle/pull/2078#issuecomment-2303864664

   ## Test Results
    2 787 files   - 5   2 787 suites   - 5   5h 43m 44s :stopwatch: - 6m 52s
      988 tests ±0     986 :white_check_mark:  - 1   1 :zzz: ±0  0 :x: ±0  1 :fire: +1 
   12 398 runs   - 5  12 382 :white_check_mark:  - 6  15 :zzz: ±0  0 :x: ±0  1 :fire: +1 
   
   For more details on these errors, see [this check](https://github.com/apache/incubator-uniffle/runs/29095084155).
   
   Results for commit 81967d13. ± Comparison against base commit 0495fbca.
   
   [test-results]:data:application/gzip;base64,H4sIACLXxmYC/03MQQ6DIBCF4asY1l0MIDD0Mg2iJKQqDcLK9O4Fo9Tl+2by78T5edrIs2MK1aMjW/bpvsccTfJhrQKS9YXKPdUPjXit15atPUj+6e0/hWgDZ/xcABpMMYZ4vsS81iZlXOM5r2gxZM3OqrjgVj32PWrDsvhUBkGqpRopBzmAs3wAEFZzR3vkwhpFJ2aAGXTk+wNRj2Q2EgEAAA==
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [#2077] improvement: Check java version in release scripts [incubator-uniffle]

Posted by "wForget (via GitHub)" <gi...@apache.org>.
wForget commented on PR #2078:
URL: https://github.com/apache/incubator-uniffle/pull/2078#issuecomment-2304036710

   > #1983 @wForget
   
   That's a good way, thank you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [#2077] improvement: Check java version in release scripts [incubator-uniffle]

Posted by "xianjingfeng (via GitHub)" <gi...@apache.org>.
xianjingfeng commented on PR #2078:
URL: https://github.com/apache/incubator-uniffle/pull/2078#issuecomment-2303938417

   #1983 @wForget 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [#2077] improvement: Check java version in release scripts [incubator-uniffle]

Posted by "wForget (via GitHub)" <gi...@apache.org>.
wForget closed pull request #2078: [#2077] improvement: Check java version in release scripts
URL: https://github.com/apache/incubator-uniffle/pull/2078


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org