Re: DERBY-688: ready for commit?

[Bryan Pendleton <bp...@amberpoint.com>]

> Otherwise, if any of my answers above would make you uncomfortable with 
> committing the patches (or with approving their commit), please let me 
> know and I will try to address your concerns.

Hi Army,

I am comfortable with your responses, and in my opinion the 5 patches
are ready for commit.

Is anybody else intending to review these patches over the next few days?

If no other reviews are underway, I propose to commit these patches by Aug 10.

A question: is it best that I should commit them as 5 separate commit
operations? An alternative would be to apply all 5 patches to my sandbox,
and then commit them with a single commit, which matches the way that I
reviewed them, but does not match the way that they are attached to the
JIRA issue. Is there any particular reason to favor one technique versus
the other?

thanks,

bryan

Re: DERBY-688: ready for commit?

[Bryan Pendleton <bp...@amberpoint.com>]

Yip Ng wrote:
> I think these patches are ready for commit.  +1

Thanks Yip!

I will proceed with committing the patches starting today.

thanks,

bryan

Re: DERBY-688: ready for commit?

[Yip Ng <yi...@gmail.com>]

Hi Army:

      I have reviewed your Derby-688 XML patches.  Thanks for continuing
improving
XML support for Derby.  I have applied the patches and was able to compile
without any problems (except for the part where I have to modified the
patches manually to remove the absolute paths).  I think Bryan have asked
most of my concerns/questions and they have
been addressed.  (Great comments in the code btw).  I think these patches
are ready
for commit.  +1

Yip


On 8/7/06, Bryan Pendleton <bp...@amberpoint.com> wrote:
>
> > Otherwise, if any of my answers above would make you uncomfortable with
> > committing the patches (or with approving their commit), please let me
> > know and I will try to address your concerns.
>
> Hi Army,
>
> I am comfortable with your responses, and in my opinion the 5 patches
> are ready for commit.
>
> Is anybody else intending to review these patches over the next few days?
>
> If no other reviews are underway, I propose to commit these patches by Aug
> 10.
>
> A question: is it best that I should commit them as 5 separate commit
> operations? An alternative would be to apply all 5 patches to my sandbox,
> and then commit them with a single commit, which matches the way that I
> reviewed them, but does not match the way that they are attached to the
> JIRA issue. Is there any particular reason to favor one technique versus
> the other?
>
> thanks,
>
> bryan
>
>

Re: DERBY-688: ready for commit?

[Daniel John Debrunner <dj...@apache.org>]

Bryan Pendleton wrote:

>> Otherwise, if any of my answers above would make you uncomfortable
>> with committing the patches (or with approving their commit), please
>> let me know and I will try to address your concerns.
> 
> 
> Hi Army,
> 
> I am comfortable with your responses, and in my opinion the 5 patches
> are ready for commit.
> 
> Is anybody else intending to review these patches over the next few days?
> 
> If no other reviews are underway, I propose to commit these patches by
> Aug 10.
> 
> A question: is it best that I should commit them as 5 separate commit
> operations? An alternative would be to apply all 5 patches to my sandbox,
> and then commit them with a single commit, which matches the way that I
> reviewed them, but does not match the way that they are attached to the
> JIRA issue. Is there any particular reason to favor one technique versus
> the other?

I'd vote for separate patches it makes it " easier to identify as a
cause of a regression after the fact".

http://wiki.apache.org/db-derby/IncrementalDevelopment

Dan.