You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Henry Robinson (Code Review)" <ge...@cloudera.org> on 2017/06/19 17:02:44 UTC
[native-toolchain-CR] IMPALA-5526: Add krb5 1.15.1 to toolchain
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7224
Change subject: IMPALA-5526: Add krb5 1.15.1 to toolchain
......................................................................
IMPALA-5526: Add krb5 1.15.1 to toolchain
Change-Id: I5237f8cba41f91e70f0a915f841db51b5cb93655
---
M buildall.sh
A source/krb5/build.sh
2 files changed, 43 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/24/7224/1
--
To view, visit http://gerrit.cloudera.org:8080/7224
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5237f8cba41f91e70f0a915f841db51b5cb93655
Gerrit-PatchSet: 1
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
[native-toolchain-CR] IMPALA-5526: Add krb5 1.15.1 to toolchain
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5526: Add krb5 1.15.1 to toolchain
......................................................................
Patch Set 2:
Carry +2. This already passed a full toolchain build.
--
To view, visit http://gerrit.cloudera.org:8080/7224
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5237f8cba41f91e70f0a915f841db51b5cb93655
Gerrit-PatchSet: 2
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-5526: Add krb5 1.15.1 to toolchain
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has submitted this change and it was merged.
Change subject: IMPALA-5526: Add krb5 1.15.1 to toolchain
......................................................................
IMPALA-5526: Add krb5 1.15.1 to toolchain
Change-Id: I5237f8cba41f91e70f0a915f841db51b5cb93655
---
M buildall.sh
A source/krb5/build.sh
2 files changed, 43 insertions(+), 0 deletions(-)
Approvals:
Henry Robinson: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/7224
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5237f8cba41f91e70f0a915f841db51b5cb93655
Gerrit-PatchSet: 2
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
[native-toolchain-CR] IMPALA-5526: Add krb5 1.15.1 to toolchain
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5526: Add krb5 1.15.1 to toolchain
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7224
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5237f8cba41f91e70f0a915f841db51b5cb93655
Gerrit-PatchSet: 2
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-5526: Add krb5 1.15.1 to toolchain
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5526: Add krb5 1.15.1 to toolchain
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7224/1/source/krb5/build.sh
File source/krb5/build.sh:
PS1, Line 2: 2015
> nit: 2017
Done
--
To view, visit http://gerrit.cloudera.org:8080/7224
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5237f8cba41f91e70f0a915f841db51b5cb93655
Gerrit-PatchSet: 1
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: Yes
[native-toolchain-CR] IMPALA-5526: Add krb5 1.15.1 to toolchain
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Hello Matthew Jacobs,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7224
to look at the new patch set (#2).
Change subject: IMPALA-5526: Add krb5 1.15.1 to toolchain
......................................................................
IMPALA-5526: Add krb5 1.15.1 to toolchain
Change-Id: I5237f8cba41f91e70f0a915f841db51b5cb93655
---
M buildall.sh
A source/krb5/build.sh
2 files changed, 43 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/24/7224/2
--
To view, visit http://gerrit.cloudera.org:8080/7224
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5237f8cba41f91e70f0a915f841db51b5cb93655
Gerrit-PatchSet: 2
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
[native-toolchain-CR] IMPALA-5526: Add krb5 1.15.1 to toolchain
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5526: Add krb5 1.15.1 to toolchain
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7224
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5237f8cba41f91e70f0a915f841db51b5cb93655
Gerrit-PatchSet: 2
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-5526: Add krb5 1.15.1 to toolchain
Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5526: Add krb5 1.15.1 to toolchain
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7224/1/source/krb5/build.sh
File source/krb5/build.sh:
PS1, Line 2: 2015
nit: 2017
--
To view, visit http://gerrit.cloudera.org:8080/7224
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5237f8cba41f91e70f0a915f841db51b5cb93655
Gerrit-PatchSet: 1
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: Yes