You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by lovexi <gi...@git.apache.org> on 2016/07/19 05:53:22 UTC
[GitHub] spark pull request #14254: Add shuffle service metrics entry in monitoring d...
GitHub user lovexi opened a pull request:
https://github.com/apache/spark/pull/14254
Add shuffle service metrics entry in monitoring docs
## What changes were proposed in this pull request?
Add shuffle service metrics entry in currently supporting metrics list in monitoring docs.
## How was this patch tested?
Check the docs for changes
JIRA link: https://issues.apache.org/jira/browse/SPARK-16619
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lovexi/spark yangyang-monitoring-doc
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/14254.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #14254
----
commit abacb11005b1fb81832a12558980814021cebae1
Author: Yangyang Liu <ya...@fb.com>
Date: 2016-07-19T05:47:48Z
Add shuffle service metrics entry in docs
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #14254: [SPARK-16619] Add shuffle service metrics entry i...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14254#discussion_r77275005
--- Diff: docs/monitoring.md ---
@@ -350,6 +350,7 @@ set of sinks to which metrics are reported. The following instances are currentl
* `worker`: A Spark standalone worker process.
* `executor`: A Spark executor.
* `driver`: The Spark driver process (the process in which your SparkContext is created).
+* `shuffleService`: The Spark shuffle service
--- End diff --
I'm adding a period at the end myself on merge so that we don't get a followup patch to do it later \U0001f604
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14254: [SPARK-16619] Add shuffle service metrics entry in monit...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14254
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #14254: [SPARK-16619] Add shuffle service metrics entry i...
Posted by lovexi <gi...@git.apache.org>.
Github user lovexi commented on a diff in the pull request:
https://github.com/apache/spark/pull/14254#discussion_r77283751
--- Diff: docs/monitoring.md ---
@@ -350,6 +350,7 @@ set of sinks to which metrics are reported. The following instances are currentl
* `worker`: A Spark standalone worker process.
* `executor`: A Spark executor.
* `driver`: The Spark driver process (the process in which your SparkContext is created).
+* `shuffleService`: The Spark shuffle service
--- End diff --
Thank you for your help. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14254: [SPARK-16619] Add shuffle service metrics entry in monit...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the issue:
https://github.com/apache/spark/pull/14254
LGTM so I'm going to merge this to master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14254: [SPARK-16619] Add shuffle service metrics entry in monit...
Posted by lovexi <gi...@git.apache.org>.
Github user lovexi commented on the issue:
https://github.com/apache/spark/pull/14254
Test it please, Jenkins.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #14254: [SPARK-16619] Add shuffle service metrics entry i...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/14254
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org