You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@carbondata.apache.org by GitBox <gi...@apache.org> on 2021/09/13 14:41:23 UTC

[GitHub] [carbondata] ShreelekhyaG opened a new pull request #4215: [WIP] Load/insert after alter add column on partition table with complex column fails

ShreelekhyaG opened a new pull request #4215:
URL: https://github.com/apache/carbondata/pull/4215


    ### Why is this PR needed?
   Insert after alter add column on partition table with complex column fails with bufferUnderFlowException 
   List of columns order in `TableSchema `is different after alter add column.
   Ex: If partition is of dimension type, when table is created the schema columns order is as
    dimension columns(partition column also) + complex column
   After alter add, we are changing the order of columns in schema by moving the partition column to last.
   complex column + partition column
   Due to this change in order, while `fillDimensionAndMeasureDetails`, the indexing is wrong as it expects complex column to be last always which causes bufferUnderFlowException while flattening complex row.
    
    ### What changes were proposed in this PR?
   After alter add, removed changes to add partition column at last. 
       
    ### Does this PR introduce any user interface change?
    - No
   
    ### Is any new testcase added?
    - Yes
   
       
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4215: [CARBONDATA-4284] Load/insert after alter add column on partition table with complex column fails

Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4215:
URL: https://github.com/apache/carbondata/pull/4215#issuecomment-920024240


   Build Success with Spark 3.1, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/316/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] kunal642 commented on pull request #4215: [CARBONDATA-4284] Load/insert after alter add column on partition table with complex column fails

Posted by GitBox <gi...@apache.org>.
kunal642 commented on pull request #4215:
URL: https://github.com/apache/carbondata/pull/4215#issuecomment-919936206


   retest this please


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4215: [CARBONDATA-4284] Load/insert after alter add column on partition table with complex column fails

Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4215:
URL: https://github.com/apache/carbondata/pull/4215#issuecomment-920037712


   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/4170/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4215: [WIP] Load/insert after alter add column on partition table with complex column fails

Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4215:
URL: https://github.com/apache/carbondata/pull/4215#issuecomment-918360777


   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/4168/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] asfgit closed pull request #4215: [CARBONDATA-4284] Load/insert after alter add column on partition table with complex column fails

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4215:
URL: https://github.com/apache/carbondata/pull/4215


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] kunal642 commented on pull request #4215: [CARBONDATA-4284] Load/insert after alter add column on partition table with complex column fails

Posted by GitBox <gi...@apache.org>.
kunal642 commented on pull request #4215:
URL: https://github.com/apache/carbondata/pull/4215#issuecomment-920615434


   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] Indhumathi27 commented on pull request #4215: [CARBONDATA-4284] Load/insert after alter add column on partition table with complex column fails

Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on pull request #4215:
URL: https://github.com/apache/carbondata/pull/4215#issuecomment-920020225


   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4215: [WIP] Load/insert after alter add column on partition table with complex column fails

Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4215:
URL: https://github.com/apache/carbondata/pull/4215#issuecomment-918386511


   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5912/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4215: [WIP] Load/insert after alter add column on partition table with complex column fails

Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4215:
URL: https://github.com/apache/carbondata/pull/4215#issuecomment-918381079


   Build Success with Spark 3.1, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/314/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4215: [CARBONDATA-4284] Load/insert after alter add column on partition table with complex column fails

Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4215:
URL: https://github.com/apache/carbondata/pull/4215#issuecomment-920037020


   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5914/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org