[jira] [Comment Edited] (KAFKA-7877) Connect DLQ not used in SinkTask put()

["Andrew Bourgeois (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-7877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16756534#comment-16756534 ] 

Andrew Bourgeois edited comment on KAFKA-7877 at 1/30/19 8:26 PM:
------------------------------------------------------------------

The following sentence:

{noformat}
For sink connectors, we will write the original record (from the Kafka topic the sink connector is consuming from) which caused the failure to a configurable Kafka topic.{noformat}
in [KIP-298|https://cwiki.apache.org/confluence/display/KAFKA/KIP-298%3A+Error+Handling+in+Connect] doesn't state that the DLQ feature only applies to the conversion and transformation phases.

 


was (Author: andrew bourgeois):
The following sentence:

{noformat}
For sink connectors, we will write the original record (from the Kafka topic the sink connector is consuming from) which caused the failure to a configurable Kafka topic.{noformat}
in [KIP-298|https://cwiki.apache.org/confluence/display/KAFKA/KIP-298%3A+Error+Handling+in+Connect] doesn't state that the DLQ feature only applies to the conversion and transformation phases. The delivery phase is excluded.

 

> Connect DLQ not used in SinkTask put()
> --------------------------------------
>
>                 Key: KAFKA-7877
>                 URL: https://issues.apache.org/jira/browse/KAFKA-7877
>             Project: Kafka
>          Issue Type: Bug
>          Components: KafkaConnect
>    Affects Versions: 2.0.0, 2.0.1, 2.1.0
>            Reporter: Andrew Bourgeois
>            Priority: Major
>
> The Dead Letter Queue isn't implemented for the put() operation.
> In [https://github.com/apache/kafka/blob/trunk/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSinkTask.java] the "retryWithToleranceOperator" gets used during the conversion and transformation phases, but not when delivering the messages to the sink task.
> According to KIP-298, the Dead Letter Queue should be used as long as we throw org.apache.kafka.connect.errors.RetriableException.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)