You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@dubbo.apache.org by Andrea Del Bene <an...@gmail.com> on 2018/08/18 16:44:20 UTC
Bom module parent
Hi,
I see that Dubbo Bom module has the Apache Foundation POM as parent and
not dubbo-parent, which also has Apache Foundation POM as parent. This
causes Maven not to consider Bom a sub module of Dubbo. It's not a big
issue but I think Bom should have dubbo-parent as parent like all the
other sub modules.
Thank you in advance.
Re: Bom module parent
Posted by Ian Luo <ia...@gmail.com>.
Thanks, I have merged it.
On Wed, Aug 22, 2018 at 10:46 PM Andrea Del Bene <an...@gmail.com>
wrote:
> Done: https://github.com/apache/incubator-dubbo/pull/2333
>
> On Wed, Aug 22, 2018 at 1:11 PM Andrea Del Bene <an...@gmail.com>
> wrote:
>
> > PR on its way :-)
> >
> > On Wed, Aug 22, 2018 at 12:30 PM Huxing Zhang <hu...@apache.org> wrote:
> >
> >> On Wed, Aug 22, 2018 at 11:52 AM Ian Luo <ia...@gmail.com> wrote:
> >> >
> >> > I think the reason Andrea gave is valid, we should consider this.
> >>
> >> +1 for consistency.
> >>
> >> Pull request is welcome!
> >>
> >> >
> >> > On Tue, Aug 21, 2018 at 11:30 PM Andrea Del Bene <
> an.delbene@gmail.com>
> >> > wrote:
> >> >
> >> > > Hi,
> >> > >
> >> > > thank you for your response.
> >> > >
> >> > >
> >> > > Thanks for your reporting Andrea.
> >> > > >
> >> > > > This causes Maven not to consider Bom a sub module of Dubbo
> >> > > >
> >> > > >
> >> > > > I think the '<module>bom</module>' in dubbo root pom.xml will make
> >> Dubbo
> >> > > > consider Bom as a sub module.
> >> > > >
> >> > > >
> >> > > Well that's right but if you don't set dubbo root pom.xml as parent
> >> you
> >> > > have some annoying side effects. For example, let's say you want to
> >> build a
> >> > > new release and to do so you use Maven version plugin like this:
> >> > >
> >> > > mvn versions:set -DnewVersion="2.6.4"
> >> > >
> >> > > If you run the command above on Dubbo root folder all submodules
> >> version
> >> > > will be updated except bom module, because it is not a direct child
> >> of root
> >> > > pom. Anyway, I don't think there is any drawback if we change bom
> >> parent to
> >> > > Dubbo root. Am I right?
> >> > >
> >> > >
> >> > >
> >> > > > Best regards,
> >> > > > Jun
> >> > > >
> >> > > > On 19 Aug 2018, at 00:44, Andrea Del Bene <an...@gmail.com>
> >> wrote:
> >> > > >
> >> > > > Hi,
> >> > > >
> >> > > > I see that Dubbo Bom module has the Apache Foundation POM as
> parent
> >> and
> >> > > > not dubbo-parent, which also has Apache Foundation POM as parent.
> >> This
> >> > > > causes Maven not to consider Bom a sub module of Dubbo. It's not a
> >> big
> >> > > > issue but I think Bom should have dubbo-parent as parent like all
> >> the
> >> > > other
> >> > > > sub modules.
> >> > > >
> >> > > > Thank you in advance.
> >> > > >
> >> > > >
> >> > > >
> >> > >
> >> > >
> >> > > --
> >> > > Andrea Del Bene.
> >> > > Apache Wicket committer.
> >> > >
> >>
> >>
> >>
> >> --
> >> Best Regards！
> >> Huxing
> >>
> >
> >
> > --
> > Andrea Del Bene.
> > Apache Wicket committer.
> >
>
>
> --
> Andrea Del Bene.
> Apache Wicket committer.
>
Re: Bom module parent
Posted by Andrea Del Bene <an...@gmail.com>.
Done: https://github.com/apache/incubator-dubbo/pull/2333
On Wed, Aug 22, 2018 at 1:11 PM Andrea Del Bene <an...@gmail.com>
wrote:
> PR on its way :-)
>
> On Wed, Aug 22, 2018 at 12:30 PM Huxing Zhang <hu...@apache.org> wrote:
>
>> On Wed, Aug 22, 2018 at 11:52 AM Ian Luo <ia...@gmail.com> wrote:
>> >
>> > I think the reason Andrea gave is valid, we should consider this.
>>
>> +1 for consistency.
>>
>> Pull request is welcome!
>>
>> >
>> > On Tue, Aug 21, 2018 at 11:30 PM Andrea Del Bene <an...@gmail.com>
>> > wrote:
>> >
>> > > Hi,
>> > >
>> > > thank you for your response.
>> > >
>> > >
>> > > Thanks for your reporting Andrea.
>> > > >
>> > > > This causes Maven not to consider Bom a sub module of Dubbo
>> > > >
>> > > >
>> > > > I think the '<module>bom</module>' in dubbo root pom.xml will make
>> Dubbo
>> > > > consider Bom as a sub module.
>> > > >
>> > > >
>> > > Well that's right but if you don't set dubbo root pom.xml as parent
>> you
>> > > have some annoying side effects. For example, let's say you want to
>> build a
>> > > new release and to do so you use Maven version plugin like this:
>> > >
>> > > mvn versions:set -DnewVersion="2.6.4"
>> > >
>> > > If you run the command above on Dubbo root folder all submodules
>> version
>> > > will be updated except bom module, because it is not a direct child
>> of root
>> > > pom. Anyway, I don't think there is any drawback if we change bom
>> parent to
>> > > Dubbo root. Am I right?
>> > >
>> > >
>> > >
>> > > > Best regards,
>> > > > Jun
>> > > >
>> > > > On 19 Aug 2018, at 00:44, Andrea Del Bene <an...@gmail.com>
>> wrote:
>> > > >
>> > > > Hi,
>> > > >
>> > > > I see that Dubbo Bom module has the Apache Foundation POM as parent
>> and
>> > > > not dubbo-parent, which also has Apache Foundation POM as parent.
>> This
>> > > > causes Maven not to consider Bom a sub module of Dubbo. It's not a
>> big
>> > > > issue but I think Bom should have dubbo-parent as parent like all
>> the
>> > > other
>> > > > sub modules.
>> > > >
>> > > > Thank you in advance.
>> > > >
>> > > >
>> > > >
>> > >
>> > >
>> > > --
>> > > Andrea Del Bene.
>> > > Apache Wicket committer.
>> > >
>>
>>
>>
>> --
>> Best Regards！
>> Huxing
>>
>
>
> --
> Andrea Del Bene.
> Apache Wicket committer.
>
--
Andrea Del Bene.
Apache Wicket committer.
Re: Bom module parent
Posted by Andrea Del Bene <an...@gmail.com>.
PR on its way :-)
On Wed, Aug 22, 2018 at 12:30 PM Huxing Zhang <hu...@apache.org> wrote:
> On Wed, Aug 22, 2018 at 11:52 AM Ian Luo <ia...@gmail.com> wrote:
> >
> > I think the reason Andrea gave is valid, we should consider this.
>
> +1 for consistency.
>
> Pull request is welcome!
>
> >
> > On Tue, Aug 21, 2018 at 11:30 PM Andrea Del Bene <an...@gmail.com>
> > wrote:
> >
> > > Hi,
> > >
> > > thank you for your response.
> > >
> > >
> > > Thanks for your reporting Andrea.
> > > >
> > > > This causes Maven not to consider Bom a sub module of Dubbo
> > > >
> > > >
> > > > I think the '<module>bom</module>' in dubbo root pom.xml will make
> Dubbo
> > > > consider Bom as a sub module.
> > > >
> > > >
> > > Well that's right but if you don't set dubbo root pom.xml as parent you
> > > have some annoying side effects. For example, let's say you want to
> build a
> > > new release and to do so you use Maven version plugin like this:
> > >
> > > mvn versions:set -DnewVersion="2.6.4"
> > >
> > > If you run the command above on Dubbo root folder all submodules
> version
> > > will be updated except bom module, because it is not a direct child of
> root
> > > pom. Anyway, I don't think there is any drawback if we change bom
> parent to
> > > Dubbo root. Am I right?
> > >
> > >
> > >
> > > > Best regards,
> > > > Jun
> > > >
> > > > On 19 Aug 2018, at 00:44, Andrea Del Bene <an...@gmail.com>
> wrote:
> > > >
> > > > Hi,
> > > >
> > > > I see that Dubbo Bom module has the Apache Foundation POM as parent
> and
> > > > not dubbo-parent, which also has Apache Foundation POM as parent.
> This
> > > > causes Maven not to consider Bom a sub module of Dubbo. It's not a
> big
> > > > issue but I think Bom should have dubbo-parent as parent like all the
> > > other
> > > > sub modules.
> > > >
> > > > Thank you in advance.
> > > >
> > > >
> > > >
> > >
> > >
> > > --
> > > Andrea Del Bene.
> > > Apache Wicket committer.
> > >
>
>
>
> --
> Best Regards！
> Huxing
>
--
Andrea Del Bene.
Apache Wicket committer.
Re: Bom module parent
Posted by Huxing Zhang <hu...@apache.org>.
On Wed, Aug 22, 2018 at 11:52 AM Ian Luo <ia...@gmail.com> wrote:
>
> I think the reason Andrea gave is valid, we should consider this.
+1 for consistency.
Pull request is welcome!
>
> On Tue, Aug 21, 2018 at 11:30 PM Andrea Del Bene <an...@gmail.com>
> wrote:
>
> > Hi,
> >
> > thank you for your response.
> >
> >
> > Thanks for your reporting Andrea.
> > >
> > > This causes Maven not to consider Bom a sub module of Dubbo
> > >
> > >
> > > I think the '<module>bom</module>' in dubbo root pom.xml will make Dubbo
> > > consider Bom as a sub module.
> > >
> > >
> > Well that's right but if you don't set dubbo root pom.xml as parent you
> > have some annoying side effects. For example, let's say you want to build a
> > new release and to do so you use Maven version plugin like this:
> >
> > mvn versions:set -DnewVersion="2.6.4"
> >
> > If you run the command above on Dubbo root folder all submodules version
> > will be updated except bom module, because it is not a direct child of root
> > pom. Anyway, I don't think there is any drawback if we change bom parent to
> > Dubbo root. Am I right?
> >
> >
> >
> > > Best regards,
> > > Jun
> > >
> > > On 19 Aug 2018, at 00:44, Andrea Del Bene <an...@gmail.com> wrote:
> > >
> > > Hi,
> > >
> > > I see that Dubbo Bom module has the Apache Foundation POM as parent and
> > > not dubbo-parent, which also has Apache Foundation POM as parent. This
> > > causes Maven not to consider Bom a sub module of Dubbo. It's not a big
> > > issue but I think Bom should have dubbo-parent as parent like all the
> > other
> > > sub modules.
> > >
> > > Thank you in advance.
> > >
> > >
> > >
> >
> >
> > --
> > Andrea Del Bene.
> > Apache Wicket committer.
> >
--
Best Regards！
Huxing
Re: Bom module parent
Posted by Ian Luo <ia...@gmail.com>.
I think the reason Andrea gave is valid, we should consider this.
On Tue, Aug 21, 2018 at 11:30 PM Andrea Del Bene <an...@gmail.com>
wrote:
> Hi,
>
> thank you for your response.
>
>
> Thanks for your reporting Andrea.
> >
> > This causes Maven not to consider Bom a sub module of Dubbo
> >
> >
> > I think the '<module>bom</module>' in dubbo root pom.xml will make Dubbo
> > consider Bom as a sub module.
> >
> >
> Well that's right but if you don't set dubbo root pom.xml as parent you
> have some annoying side effects. For example, let's say you want to build a
> new release and to do so you use Maven version plugin like this:
>
> mvn versions:set -DnewVersion="2.6.4"
>
> If you run the command above on Dubbo root folder all submodules version
> will be updated except bom module, because it is not a direct child of root
> pom. Anyway, I don't think there is any drawback if we change bom parent to
> Dubbo root. Am I right?
>
>
>
> > Best regards,
> > Jun
> >
> > On 19 Aug 2018, at 00:44, Andrea Del Bene <an...@gmail.com> wrote:
> >
> > Hi,
> >
> > I see that Dubbo Bom module has the Apache Foundation POM as parent and
> > not dubbo-parent, which also has Apache Foundation POM as parent. This
> > causes Maven not to consider Bom a sub module of Dubbo. It's not a big
> > issue but I think Bom should have dubbo-parent as parent like all the
> other
> > sub modules.
> >
> > Thank you in advance.
> >
> >
> >
>
>
> --
> Andrea Del Bene.
> Apache Wicket committer.
>
Re: Bom module parent
Posted by Andrea Del Bene <an...@gmail.com>.
Hi,
thank you for your response.
Thanks for your reporting Andrea.
>
> This causes Maven not to consider Bom a sub module of Dubbo
>
>
> I think the '<module>bom</module>' in dubbo root pom.xml will make Dubbo
> consider Bom as a sub module.
>
>
Well that's right but if you don't set dubbo root pom.xml as parent you
have some annoying side effects. For example, let's say you want to build a
new release and to do so you use Maven version plugin like this:
mvn versions:set -DnewVersion="2.6.4"
If you run the command above on Dubbo root folder all submodules version
will be updated except bom module, because it is not a direct child of root
pom. Anyway, I don't think there is any drawback if we change bom parent to
Dubbo root. Am I right?
> Best regards,
> Jun
>
> On 19 Aug 2018, at 00:44, Andrea Del Bene <an...@gmail.com> wrote:
>
> Hi,
>
> I see that Dubbo Bom module has the Apache Foundation POM as parent and
> not dubbo-parent, which also has Apache Foundation POM as parent. This
> causes Maven not to consider Bom a sub module of Dubbo. It's not a big
> issue but I think Bom should have dubbo-parent as parent like all the other
> sub modules.
>
> Thank you in advance.
>
>
>
--
Andrea Del Bene.
Apache Wicket committer.
Re: Bom module parent
Posted by jun liu <ke...@gmail.com>.
Thanks for your reporting Andrea.
> This causes Maven not to consider Bom a sub module of Dubbo
I think the '<module>bom</module>' in dubbo root pom.xml will make Dubbo consider Bom as a sub module.
Best regards,
Jun
> On 19 Aug 2018, at 00:44, Andrea Del Bene <an...@gmail.com> wrote:
>
> Hi,
>
> I see that Dubbo Bom module has the Apache Foundation POM as parent and not dubbo-parent, which also has Apache Foundation POM as parent. This causes Maven not to consider Bom a sub module of Dubbo. It's not a big issue but I think Bom should have dubbo-parent as parent like all the other sub modules.
>
> Thank you in advance.
>