You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/02/10 07:06:09 UTC
[GitHub] [netbeans] jlahoda opened a new pull request #1940: Fix member
references in Jackpot scripts
jlahoda opened a new pull request #1940: Fix member references in Jackpot scripts
URL: https://github.com/apache/netbeans/pull/1940
Fixing three problems related to the declarative Java hints:
-the declarative hints use :: as a separator between snippets and conditions - but :: is also used in meber references. So this patch is trying to disambiguate the two uses.
-implicit lambdas in the target snippets get erroneously explicit parameter handling (i.e. get types for the parameter names, often even wrong like "(ERROR)")
-for implicit lambdas with a single parameters, the parameter is still wrapped with parentheses
--added a configuration option for this; and this may be the most doubtful thing in the patch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] jlahoda merged pull request #1940: Fix member references
in Jackpot scripts
Posted by GitBox <gi...@apache.org>.
jlahoda merged pull request #1940: Fix member references in Jackpot scripts
URL: https://github.com/apache/netbeans/pull/1940
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] AlexFalappa commented on issue #1940: Fix member
references in Jackpot scripts
Posted by GitBox <gi...@apache.org>.
AlexFalappa commented on issue #1940: Fix member references in Jackpot scripts
URL: https://github.com/apache/netbeans/pull/1940#issuecomment-584130254
I like the code style change for having no parenthesis around single parameters lambdas.
I always found myself removing them after invoking code completion.
Another thing I would like to see is no explicit body in code completion of lambdas, i.e. having this:
```java
aStream.filter(s -> | );
```
instead of this:
```java
aStream.filter((s) -> {
return false; //To change body of generated lambdas, choose Tools | Templates.
});|
```
where `|` denotes the final cursor position.
But I agree this should be covered in a different PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists