You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2017/11/29 21:14:40 UTC

[kudu-CR] docs: 1.6 release notes for disk failure 

Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8686


Change subject: docs: 1.6 release notes for disk failure
......................................................................

docs: 1.6 release notes for disk failure

Change-Id: I611cb203ea61ee3936cec7622663fc054ae4d115
---
M docs/release_notes.adoc
1 file changed, 7 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/8686/1
-- 
To view, visit http://gerrit.cloudera.org:8080/8686
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I611cb203ea61ee3936cec7622663fc054ae4d115
Gerrit-Change-Number: 8686
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>

[kudu-CR] docs: 1.6 release notes for new data dir features

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8686 )

Change subject: docs: 1.6 release notes for new data dir features
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8686/3/docs/release_notes.adoc
File docs/release_notes.adoc:

http://gerrit.cloudera.org:8080/#/c/8686/3/docs/release_notes.adoc@55
PS3, Line 55:   parallelism. Note that the first configured data directory and the WAL
> This is now enabled by default and so I think we can call it a new feature 
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/8686
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I611cb203ea61ee3936cec7622663fc054ae4d115
Gerrit-Change-Number: 8686
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Wed, 29 Nov 2017 23:18:17 +0000
Gerrit-HasComments: Yes

[kudu-CR] docs: 1.6 release notes for new data dir features

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8686 )

Change subject: docs: 1.6 release notes for new data dir features
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8686/4/docs/release_notes.adoc
File docs/release_notes.adoc:

http://gerrit.cloudera.org:8080/#/c/8686/4/docs/release_notes.adoc@53
PS4, Line 53: e ex
> the default is to create groups containing all available disks.
mind mentioning that fact here in the release note?



-- 
To view, visit http://gerrit.cloudera.org:8080/8686
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I611cb203ea61ee3936cec7622663fc054ae4d115
Gerrit-Change-Number: 8686
Gerrit-PatchSet: 6
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 30 Nov 2017 00:11:13 +0000
Gerrit-HasComments: Yes

[kudu-CR] docs: 1.6 release notes for new data dir features

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/8686

to look at the new patch set (#6).

Change subject: docs: 1.6 release notes for new data dir features
......................................................................

docs: 1.6 release notes for new data dir features

Change-Id: I611cb203ea61ee3936cec7622663fc054ae4d115
---
M docs/release_notes.adoc
1 file changed, 17 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/8686/6
-- 
To view, visit http://gerrit.cloudera.org:8080/8686
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I611cb203ea61ee3936cec7622663fc054ae4d115
Gerrit-Change-Number: 8686
Gerrit-PatchSet: 6
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>

[kudu-CR] docs: 1.6 release notes for new data dir features

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8686 )

Change subject: docs: 1.6 release notes for new data dir features
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8686/4/docs/release_notes.adoc
File docs/release_notes.adoc:

http://gerrit.cloudera.org:8080/#/c/8686/4/docs/release_notes.adoc@53
PS4, Line 53: e ex
> mind mentioning that fact here in the release note?
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/8686
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I611cb203ea61ee3936cec7622663fc054ae4d115
Gerrit-Change-Number: 8686
Gerrit-PatchSet: 6
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 30 Nov 2017 00:15:28 +0000
Gerrit-HasComments: Yes

[kudu-CR] docs: 1.6 release notes for new data dir features

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8686 )

Change subject: docs: 1.6 release notes for new data dir features
......................................................................


Patch Set 6: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/8686
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I611cb203ea61ee3936cec7622663fc054ae4d115
Gerrit-Change-Number: 8686
Gerrit-PatchSet: 6
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 30 Nov 2017 00:15:59 +0000
Gerrit-HasComments: No

[kudu-CR] docs: 1.6 release notes for new data dir features

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8686 )

Change subject: docs: 1.6 release notes for new data dir features
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8686/3/docs/release_notes.adoc
File docs/release_notes.adoc:

http://gerrit.cloudera.org:8080/#/c/8686/3/docs/release_notes.adoc@55
PS3, Line 55: * Tablet servers' experimental tolerance of disk failures has been extended
This is now enabled by default and so I think we can call it a new feature and not experimental



-- 
To view, visit http://gerrit.cloudera.org:8080/8686
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I611cb203ea61ee3936cec7622663fc054ae4d115
Gerrit-Change-Number: 8686
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Wed, 29 Nov 2017 23:12:05 +0000
Gerrit-HasComments: Yes

[kudu-CR] docs: 1.6 release notes for new data dir features

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8686 )

Change subject: docs: 1.6 release notes for new data dir features
......................................................................

docs: 1.6 release notes for new data dir features

Change-Id: I611cb203ea61ee3936cec7622663fc054ae4d115
Reviewed-on: http://gerrit.cloudera.org:8080/8686
Reviewed-by: Mike Percy <mp...@apache.org>
Tested-by: Mike Percy <mp...@apache.org>
---
M docs/release_notes.adoc
1 file changed, 17 insertions(+), 1 deletion(-)

Approvals:
  Mike Percy: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/8686
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I611cb203ea61ee3936cec7622663fc054ae4d115
Gerrit-Change-Number: 8686
Gerrit-PatchSet: 7
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>

[kudu-CR] docs: 1.6 release notes for new data dir features

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/8686

to look at the new patch set (#3).

Change subject: docs: 1.6 release notes for new data dir features
......................................................................

docs: 1.6 release notes for new data dir features

Change-Id: I611cb203ea61ee3936cec7622663fc054ae4d115
---
M docs/release_notes.adoc
1 file changed, 15 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/8686/3
-- 
To view, visit http://gerrit.cloudera.org:8080/8686
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I611cb203ea61ee3936cec7622663fc054ae4d115
Gerrit-Change-Number: 8686
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>

[kudu-CR] docs: 1.6 release notes for new data dir features

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8686 )

Change subject: docs: 1.6 release notes for new data dir features
......................................................................


Patch Set 4:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/8686/4/docs/release_notes.adoc
File docs/release_notes.adoc:

http://gerrit.cloudera.org:8080/#/c/8686/4/docs/release_notes.adoc@48
PS4, Line 48: has been extended past startup
is now enabled by default and has been extended to handle data disk failures at runtime


http://gerrit.cloudera.org:8080/#/c/8686/4/docs/release_notes.adoc@49
PS4, Line 49: the failed
a failed


http://gerrit.cloudera.org:8080/#/c/8686/4/docs/release_notes.adoc@49
PS4, Line 49: tablets
any tablet


http://gerrit.cloudera.org:8080/#/c/8686/4/docs/release_notes.adoc@50
PS4, Line 50: will be stopped from doing further I/O and will be replicated as needed
will be shut down and restarted on a different tablet server


http://gerrit.cloudera.org:8080/#/c/8686/4/docs/release_notes.adoc@52
PS4, Line 52: parallelization of I/O
ability to parallelize reads


http://gerrit.cloudera.org:8080/#/c/8686/4/docs/release_notes.adoc@53
PS4, Line 53: flag
(what is the default at the time of writing?)



-- 
To view, visit http://gerrit.cloudera.org:8080/8686
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I611cb203ea61ee3936cec7622663fc054ae4d115
Gerrit-Change-Number: 8686
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Wed, 29 Nov 2017 23:25:15 +0000
Gerrit-HasComments: Yes

[kudu-CR] docs: 1.6 release notes for new data dir features

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/8686

to look at the new patch set (#4).

Change subject: docs: 1.6 release notes for new data dir features
......................................................................

docs: 1.6 release notes for new data dir features

Change-Id: I611cb203ea61ee3936cec7622663fc054ae4d115
---
M docs/release_notes.adoc
1 file changed, 15 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/8686/4
-- 
To view, visit http://gerrit.cloudera.org:8080/8686
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I611cb203ea61ee3936cec7622663fc054ae4d115
Gerrit-Change-Number: 8686
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>

[kudu-CR] docs: 1.6 release notes for new data dir features

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8686 )

Change subject: docs: 1.6 release notes for new data dir features
......................................................................


Patch Set 6: Verified+1

self-verifying since it's just a release note


-- 
To view, visit http://gerrit.cloudera.org:8080/8686
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I611cb203ea61ee3936cec7622663fc054ae4d115
Gerrit-Change-Number: 8686
Gerrit-PatchSet: 6
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 30 Nov 2017 00:22:05 +0000
Gerrit-HasComments: No

[kudu-CR] docs: 1.6 release notes for new data dir features

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/8686

to look at the new patch set (#5).

Change subject: docs: 1.6 release notes for new data dir features
......................................................................

docs: 1.6 release notes for new data dir features

Change-Id: I611cb203ea61ee3936cec7622663fc054ae4d115
---
M docs/release_notes.adoc
1 file changed, 16 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/8686/5
-- 
To view, visit http://gerrit.cloudera.org:8080/8686
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I611cb203ea61ee3936cec7622663fc054ae4d115
Gerrit-Change-Number: 8686
Gerrit-PatchSet: 5
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>

[kudu-CR] docs: 1.6 release notes for new data dir features

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8686 )

Change subject: docs: 1.6 release notes for new data dir features
......................................................................


Patch Set 5:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/8686/4/docs/release_notes.adoc
File docs/release_notes.adoc:

http://gerrit.cloudera.org:8080/#/c/8686/4/docs/release_notes.adoc@48
PS4, Line 48: is now enabled by default and 
> is now enabled by default and has been extended to handle data disk failure
Done


http://gerrit.cloudera.org:8080/#/c/8686/4/docs/release_notes.adoc@49
PS4, Line 49: he event o
> a failed
Done


http://gerrit.cloudera.org:8080/#/c/8686/4/docs/release_notes.adoc@49
PS4, Line 49: ures at
> any tablet
Done


http://gerrit.cloudera.org:8080/#/c/8686/4/docs/release_notes.adoc@50
PS4, Line 50: k failure at runtime, any tablets with data on a failed disk will be
> will be shut down and restarted on a different tablet server
Done


http://gerrit.cloudera.org:8080/#/c/8686/4/docs/release_notes.adoc@52
PS4, Line 52: ly added tablet's tole
> ability to parallelize reads
Done


http://gerrit.cloudera.org:8080/#/c/8686/4/docs/release_notes.adoc@53
PS4, Line 53: e ex
> (what is the default at the time of writing?)
the default is to create groups containing all available disks.



-- 
To view, visit http://gerrit.cloudera.org:8080/8686
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I611cb203ea61ee3936cec7622663fc054ae4d115
Gerrit-Change-Number: 8686
Gerrit-PatchSet: 5
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Wed, 29 Nov 2017 23:33:24 +0000
Gerrit-HasComments: Yes

[kudu-CR] docs: 1.6 release notes for new data dir features

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/8686

to look at the new patch set (#2).

Change subject: docs: 1.6 release notes for new data dir features
......................................................................

docs: 1.6 release notes for new data dir features

Change-Id: I611cb203ea61ee3936cec7622663fc054ae4d115
---
M docs/release_notes.adoc
1 file changed, 16 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/8686/2
-- 
To view, visit http://gerrit.cloudera.org:8080/8686
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I611cb203ea61ee3936cec7622663fc054ae4d115
Gerrit-Change-Number: 8686
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>

[kudu-CR] docs: 1.6 release notes for disk failure

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8686 )

Change subject: docs: 1.6 release notes for disk failure
......................................................................


Patch Set 1:

I copied and adjusted the note from 1.5 (https://kudu.apache.org/docs/release_notes.html). Could shorten it to basically just the first sentence if we don't want to duplicate the comment on limitations/tradeoffs.


-- 
To view, visit http://gerrit.cloudera.org:8080/8686
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I611cb203ea61ee3936cec7622663fc054ae4d115
Gerrit-Change-Number: 8686
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Wed, 29 Nov 2017 21:16:39 +0000
Gerrit-HasComments: No