You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/08/03 17:53:50 UTC

[GitHub] [pulsar] andrasbeni opened a new pull request, #16936: [improve][doc] Document configuration added by PIP-145

andrasbeni opened a new pull request, #16936:
URL: https://github.com/apache/pulsar/pull/16936

   Master Issue: #14505
   
   ### Motivation
   
   Documentation for the new configuration properties was missing when the feature was merged. 
   
   ### Modifications
   
   Added the new configuration properties to standalone.conf and broker.conf. Also, added documentation to site2/docs/reference-configuration.md .
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (no)
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no)
   
   ### Documentation  
   - [X] `doc` 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] andrasbeni commented on a diff in pull request #16936: [improve][doc] Document configuration added by PIP-145

Posted by GitBox <gi...@apache.org>.
andrasbeni commented on code in PR #16936:
URL: https://github.com/apache/pulsar/pull/16936#discussion_r937921557


##########
site2/docs/reference-configuration-broker.md:
##########
@@ -2329,6 +2329,26 @@ Interval between checks to see if message publish buffer size is exceed the max
 
 **Category**: Server
 
+### enableBrokerSideSubscriptionPatternEvaluation

Review Comment:
   Thanks for the review. Changes to the .md files have been reverted.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] andrasbeni commented on a diff in pull request #16936: [improve][doc] Document configuration added by PIP-145

Posted by GitBox <gi...@apache.org>.
andrasbeni commented on code in PR #16936:
URL: https://github.com/apache/pulsar/pull/16936#discussion_r944301065


##########
site2/docs/reference-configuration-broker.md:
##########
@@ -2329,6 +2329,26 @@ Interval between checks to see if message publish buffer size is exceed the max
 
 **Category**: Server
 
+### enableBrokerSideSubscriptionPatternEvaluation

Review Comment:
   @Anonymitaet, as I can see, #16865 is not going to be merged. What can I do now to get this PR merged?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] andrasbeni commented on pull request #16936: [improve][doc] Document configuration added by PIP-145

Posted by GitBox <gi...@apache.org>.
andrasbeni commented on PR #16936:
URL: https://github.com/apache/pulsar/pull/16936#issuecomment-1222864187

   /pulsarbot rerun-failure-checks
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] SignorMercurio commented on a diff in pull request #16936: [improve][doc] Document configuration added by PIP-145

Posted by GitBox <gi...@apache.org>.
SignorMercurio commented on code in PR #16936:
URL: https://github.com/apache/pulsar/pull/16936#discussion_r937535538


##########
site2/docs/reference-configuration-broker.md:
##########
@@ -2329,6 +2329,26 @@ Interval between checks to see if message publish buffer size is exceed the max
 
 **Category**: Server
 
+### enableBrokerSideSubscriptionPatternEvaluation

Review Comment:
   Totally right.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on a diff in pull request #16936: [improve][doc] Document configuration added by PIP-145

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on code in PR #16936:
URL: https://github.com/apache/pulsar/pull/16936#discussion_r951249986


##########
site2/docs/reference-configuration-broker.md:
##########
@@ -2329,6 +2329,26 @@ Interval between checks to see if message publish buffer size is exceed the max
 
 **Category**: Server
 
+### enableBrokerSideSubscriptionPatternEvaluation

Review Comment:
   @andrasbeni we can merge this PR after all tests pass



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on a diff in pull request #16936: [improve][doc] Document configuration added by PIP-145

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on code in PR #16936:
URL: https://github.com/apache/pulsar/pull/16936#discussion_r945540903


##########
conf/broker.conf:
##########
@@ -603,6 +603,14 @@ topicLevelPoliciesEnabled=true
 # If it is set to 0 or a negative number, the fenced topic will not be closed.
 topicFencingTimeoutSeconds=0
 
+# Enable the evaluation of subscription patterns on the broker.
+# if true the broker only sends the list of matching topics to the clients.

Review Comment:
   ```suggestion
   # Setting it to true means the broker only sends the list of matching topics to the clients.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] andrasbeni commented on pull request #16936: [improve][doc] Document configuration added by PIP-145

Posted by GitBox <gi...@apache.org>.
andrasbeni commented on PR #16936:
URL: https://github.com/apache/pulsar/pull/16936#issuecomment-1244122854

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet merged pull request #16936: [improve][doc] Document configuration added by PIP-145

Posted by GitBox <gi...@apache.org>.
Anonymitaet merged PR #16936:
URL: https://github.com/apache/pulsar/pull/16936


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] andrasbeni commented on pull request #16936: [improve][doc] Document configuration added by PIP-145

Posted by GitBox <gi...@apache.org>.
andrasbeni commented on PR #16936:
URL: https://github.com/apache/pulsar/pull/16936#issuecomment-1224316760

   
   /pulsarbot rerun-failure-checks
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on a diff in pull request #16936: [improve][doc] Document configuration added by PIP-145

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on code in PR #16936:
URL: https://github.com/apache/pulsar/pull/16936#discussion_r937532628


##########
site2/docs/reference-configuration-broker.md:
##########
@@ -2329,6 +2329,26 @@ Interval between checks to see if message publish buffer size is exceed the max
 
 **Category**: Server
 
+### enableBrokerSideSubscriptionPatternEvaluation

Review Comment:
   Hi @SignorMercurio 
   
   before https://github.com/apache/pulsar/pull/16865 gets merged and takes effect, do we allow users to update configuration md files manually? I think no, right? 
   
   Because after your PR gets merged and takes effect, the new changes will be synced and shown on the website, right？



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on a diff in pull request #16936: [improve][doc] Document configuration added by PIP-145

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on code in PR #16936:
URL: https://github.com/apache/pulsar/pull/16936#discussion_r937538865


##########
site2/docs/reference-configuration-broker.md:
##########
@@ -2329,6 +2329,26 @@ Interval between checks to see if message publish buffer size is exceed the max
 
 **Category**: Server
 
+### enableBrokerSideSubscriptionPatternEvaluation

Review Comment:
   @andrasbeni thanks for your contribution! We're trying to generate configuration doc from code automatically to avoid manual work https://github.com/apache/pulsar/issues/13453, could you please revert the changes to `.md` files?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org